refactor: use D3 general update pattern for series management#268
Merged
streamcode9 merged 1 commit intoFeb 12, 2026
Merged
Conversation
Make series management more D3-idiomatic by implementing the general update pattern with enter/update/exit transitions. This enables dynamic series addition/removal and provides a foundation for future features like smooth transitions and runtime series updates. **Changes:** - Update `Series` interface to store D3 selections instead of raw DOM nodes - Implement data-driven series creation with enter/update/exit pattern - Add unique IDs to series for object constancy - Use `.attr()` method throughout instead of `.setAttribute()` - Update `LegendSeriesInfo` to use D3 selections - Update all tests to work with the new selection-based API **Benefits:** - More idiomatic D3 code using declarative data joins - Enables dynamic series updates without recreating the chart - Sets foundation for transitions and animations - Better integration with D3 ecosystem - All 233 tests passing https://claude.ai/code/session_01BC9cf5VZjfDBqxD6Vz18qi
✅ Deploy Preview for endearing-pothos-ca88dc ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make series management more D3-idiomatic by implementing the general update pattern with enter/update/exit transitions. This enables dynamic series addition/removal and provides a foundation for future features like smooth transitions and runtime series updates.
Changes:
Seriesinterface to store D3 selections instead of raw DOM nodes.attr()method throughout instead of.setAttribute()LegendSeriesInfoto use D3 selectionsBenefits:
https://claude.ai/code/session_01BC9cf5VZjfDBqxD6Vz18qi