Skip to content

fix: use correct argument during error message interpolation and update descriptions #13105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kgryte merged 3 commits into from
Jun 25, 2026
Merged

fix: use correct argument during error message interpolation and update descriptions #13105

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e383803
fix: report shape argument value in `ndarray/matrix/ctor` shape error
claude Jun 24, 2026
e66fd53
docs: align `blas/ext/base/slogspace` ndarray.native JSDoc with sibling
claude Jun 24, 2026
90854dd
docs: fix `zxsy` description in `blas/ext/base/ndarray` namespace TOC
claude Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/ext/base/ndarray/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -162,7 +162,7 @@ The namespace exposes the following APIs:
- <span class="signature">[`zunitspace( arrays )`][@stdlib/blas/ext/base/ndarray/zunitspace]</span><span class="delimiter">: </span><span class="description">fill a one-dimensional double-precision complex floating-point ndarray with linearly spaced numeric elements which increment by `1` starting from a specified value.</span>
- <span class="signature">[`zxpy( arrays )`][@stdlib/blas/ext/base/ndarray/zxpy]</span><span class="delimiter">: </span><span class="description">add elements of a one-dimensional double-precision complex floating-point ndarray to the corresponding elements of a second one-dimensional double-precision complex floating-point ndarray and assign the results to the second ndarray.</span>
- <span class="signature">[`zxsa( arrays )`][@stdlib/blas/ext/base/ndarray/zxsa]</span><span class="delimiter">: </span><span class="description">subtract a scalar constant from each element in a one-dimensional double-precision complex floating-point ndarray.</span>
- <span class="signature">[`zxsy( arrays )`][@stdlib/blas/ext/base/ndarray/zxsy]</span><span class="delimiter">: </span><span class="description">subtract elements of an output one-dimensional double-precision complex floating-point ndarray from the corresponding elements in an input one-dimensional double-precision complex floating-point ndarray and assign the results to the output ndarray.</span>
- <span class="signature">[`zxsy( arrays )`][@stdlib/blas/ext/base/ndarray/zxsy]</span><span class="delimiter">: </span><span class="description">subtract the elements of an output one-dimensional double-precision complex floating-point ndarray from the corresponding elements in an input one-dimensional double-precision complex floating-point ndarray and assign the results to the output ndarray.</span>
- <span class="signature">[`zzeroTo( arrays )`][@stdlib/blas/ext/base/ndarray/zzero-to]</span><span class="delimiter">: </span><span class="description">fill a one-dimensional double-precision complex floating-point ndarray with linearly spaced numeric elements which increment by `1` starting from zero.</span>

</div>
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/blas/ext/base/slogspace/lib/ndarray.native.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ var addon = require( './../src/addon.node' );
// MAIN //

/**
* Fills a single-precision floating-point strided array with logarithmically spaced values over a specified interval using alternative indexing semantics.
* Fills a single-precision floating-point strided array with logarithmically spaced values over a specified interval.
*
* @param {PositiveInteger} N - number of indexed elements
* @param {number} base - base of the logarithmic scale
Expand Down
2 changes: 1 addition & 1 deletion lib/node_modules/@stdlib/ndarray/matrix/ctor/lib/main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,7 +354,7 @@
* var dt = String( getDType( arr ) );
* // returns 'float64'
*/
function matrix() { // eslint-disable-line max-statements

Check warning on line 357 in lib/node_modules/@stdlib/ndarray/matrix/ctor/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

Function 'matrix' has too many lines (210). Maximum allowed is 200
var nargs;
var arg0;
var arg1;
Expand Down Expand Up @@ -566,7 +566,7 @@
}
// Case: matrix( ArrayBuffer, byteOffset, shape, dtype, options )
if ( !isNonNegativeIntegerArray( arg2 ) || arg2.length !== 2 ) {
throw new TypeError( format( 'invalid argument. Third argument must be a valid shape. Value: `%s`.', arg3 ) );
throw new TypeError( format( 'invalid argument. Third argument must be a valid shape. Value: `%s`.', arg2 ) );
}
if ( !isDataType( arg3 ) ) {
throw new TypeError( format( 'invalid argument. Fourth argument must be a recognized/supported data type. Value: `%s`.', arg3 ) );
Expand All @@ -588,7 +588,7 @@
}
if ( !isNonNegativeInteger( arg2 ) ) {
throw new TypeError( format( 'invalid argument. Third argument must be a nonnegative integer. Value: `%s`.', arg2 ) );
}

Check warning on line 591 in lib/node_modules/@stdlib/ndarray/matrix/ctor/lib/main.js

View workflow job for this annotation

GitHub Actions / Lint Changed Files 

File has too many lines (315). Maximum allowed is 300
if ( !isNonNegativeInteger( arg3 ) ) {
throw new TypeError( format( 'invalid argument. Fourth argument must be a nonnegative integer. Value: `%s`.', arg3 ) );
}
Expand Down