Skip to content

fix: use correct argument during error message interpolation and update descriptions#13105

Merged
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-06-24
Jun 25, 2026
Merged

fix: use correct argument during error message interpolation and update descriptions#13105
kgryte merged 3 commits into
developfrom
philipp/fix-commit-review-2026-06-24

Conversation

@Planeshifter

Copy link
Copy Markdown
Member

Follow-up fixes for commits merged to develop between 2026-06-23 22:06 PT and 2026-06-24 04:09 PT (efdecd0..8bf91614, 26 first-parent merges).

Description

This pull request applies three high-signal follow-up corrections surfaced by a four-agent review (two style audits + two bug scans) of the last 24 hours of commits to develop.

ndarray/matrix/ctor

  • ndarray/matrix/ctor/lib/main.js (dc9a2a7): the ArrayBuffer overload's TypeError for an invalid shape argument (arg2) erroneously formatted arg3 (dtype) into the Value: %s slot; replaced arg3 with arg2 in the format() call.

blas/ext/base/slogspace

  • blas/ext/base/slogspace/lib/ndarray.native.js (01e7714): JSDoc summary appended using alternative indexing semantics, a copy-paste artifact absent from the parallel dlogspace native wrapper and slogspace's own ndarray.js; removed the trailing phrase to match sibling descriptions.

blas/ext/base/ndarray

  • lib/node_modules/@stdlib/blas/ext/base/ndarray/README.md (1d854da): the zxsy table-of-contents entry read "subtract elements" while all four sibling xsy entries read "subtract the elements"; inserted the missing definite article.

Related Issues

This pull request has no related issues.

Questions

No.

Other

Validation

Reviewer pool: two sonnet style-compliance auditors (split across new packages vs. modifications to existing packages) and two opus bug scanners. Each was briefed with a per-commit summary of the window so deliberate choices would not be flagged.

What was checked:

  • stdlib code style guide compliance (docs/style-guides/javascript, docs/style-guides/text) against established reference packages of similar shape (e.g. dnanasum for the new BLAS-ext additions, ndarray/vector/ctor for ndarray/matrix/ctor, is-floating-point-data-type for the new ndarray/base/assert packages).
  • Obvious runtime bugs visible in the diff alone (off-by-one, swapped arguments, copy-paste residue, mismatched JSDoc/signature).
  • Introduced security/logic problems (Napi error-path checks, contract violations, type-signature/runtime mismatches).
  • Documentation typos in user-visible identifiers, descriptions, and copy.

What was deliberately excluded:

  • Subjective preferences and "consider…" suggestions.
  • Issues that would require touching code outside the diff window to validate or to fix.
  • Single-reviewer findings that could not be independently re-verified by re-reading the diff.

The shape-error fix was independently surfaced by three of four reviewers; both docs fixes were single-reviewer findings re-verified directly against the diff before inclusion.

Checklist

AI Assistance

  • Yes
  • No

If you answered "yes" above, how did you use AI assistance?

  • Code generation (e.g., when writing an implementation or fixing a bug)
  • Test/benchmark generation
  • Documentation (including examples)
  • Research and understanding

Disclosure

This PR was authored by Claude Code running as a scheduled review routine: four parallel reviewer agents scanned the last 24 hours of develop, findings were cross-validated, three were retained, and the fixes (one line each) were applied in this branch. A human maintainer should audit before promoting from draft.



Generated by Claude Code

claude added 3 commits June 24, 2026 12:22
The `matrix( ArrayBuffer, byteOffset, shape, dtype, options )` overload
checks `arg2` (the shape) but the resulting TypeError formats `arg3`
(the dtype) into the `Value: %s` slot, so the printed value never
matches the offending argument.
The native ndarray-wrapper description picked up a trailing
`using alternative indexing semantics` phrase absent from the parallel
`dlogspace` wrapper and from `slogspace`'s own non-native variant. Drop
it so the four parallel descriptions agree.
The newly-added `zxsy` table-of-contents entry read `subtract elements`
while the four sibling `xsy` entries added in the same commit
(`cxsy`, `dxsy`, `gxsy`, `sxsy`) all read `subtract the elements`.
@stdlib-bot

Copy link
Copy Markdown
Contributor

Coverage Report

Package Statements Branches Functions Lines
blas/ext/base/ndarray $\\color{red}14498/15623$
$\\color{green}+92.80\\%$
$\\color{red}245/251$
$\\color{green}+97.61\\%$
$\\color{red}0/125$
$\\color{green}+0.00\\%$
$\\color{red}14498/15623$
$\\color{green}+92.80\\%$
blas/ext/base/slogspace $\\color{green}431/431$
$\\color{green}+100.00\\%$
$\\color{green}24/24$
$\\color{green}+100.00\\%$
$\\color{green}4/4$
$\\color{green}+100.00\\%$
$\\color{green}431/431$
$\\color{green}+100.00\\%$
ndarray/matrix/ctor $\\color{green}1296/1296$
$\\color{green}+100.00\\%$
$\\color{green}255/255$
$\\color{green}+100.00\\%$
$\\color{green}7/7$
$\\color{green}+100.00\\%$
$\\color{green}1296/1296$
$\\color{green}+100.00\\%$

The above coverage report was generated for the changes in this PR.

@kgryte kgryte marked this pull request as ready for review June 25, 2026 07:01
@kgryte kgryte requested a review from a team June 25, 2026 07:01
@kgryte kgryte changed the title fix: follow-up corrections to commits merged 2026-06-23/24 fix: use correct argument during error message interpolation and update descriptions Jun 25, 2026
@kgryte kgryte merged commit 92b5eb4 into develop Jun 25, 2026
20 checks passed
@kgryte kgryte deleted the philipp/fix-commit-review-2026-06-24 branch June 25, 2026 07:02
@stdlib-bot stdlib-bot added Needs Review A pull request which needs code review. and removed Needs Review A pull request which needs code review. labels Jun 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants