fix: use correct argument during error message interpolation and update descriptions#13105
Merged
Merged
Conversation
The `matrix( ArrayBuffer, byteOffset, shape, dtype, options )` overload checks `arg2` (the shape) but the resulting TypeError formats `arg3` (the dtype) into the `Value: %s` slot, so the printed value never matches the offending argument.
The native ndarray-wrapper description picked up a trailing `using alternative indexing semantics` phrase absent from the parallel `dlogspace` wrapper and from `slogspace`'s own non-native variant. Drop it so the four parallel descriptions agree.
The newly-added `zxsy` table-of-contents entry read `subtract elements` while the four sibling `xsy` entries added in the same commit (`cxsy`, `dxsy`, `gxsy`, `sxsy`) all read `subtract the elements`.
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
kgryte
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up fixes for commits merged to
developbetween 2026-06-23 22:06 PT and 2026-06-24 04:09 PT (efdecd0..8bf91614, 26 first-parent merges).Description
This pull request applies three high-signal follow-up corrections surfaced by a four-agent review (two style audits + two bug scans) of the last 24 hours of commits to
develop.ndarray/matrix/ctorndarray/matrix/ctor/lib/main.js(dc9a2a7): theArrayBufferoverload'sTypeErrorfor an invalidshapeargument (arg2) erroneously formattedarg3(dtype) into theValue: %sslot; replacedarg3witharg2in theformat()call.blas/ext/base/slogspaceblas/ext/base/slogspace/lib/ndarray.native.js(01e7714): JSDoc summary appendedusing alternative indexing semantics, a copy-paste artifact absent from the paralleldlogspacenative wrapper andslogspace's ownndarray.js; removed the trailing phrase to match sibling descriptions.blas/ext/base/ndarraylib/node_modules/@stdlib/blas/ext/base/ndarray/README.md(1d854da): thezxsytable-of-contents entry read "subtract elements" while all four siblingxsyentries read "subtract the elements"; inserted the missing definite article.Related Issues
This pull request has no related issues.
Questions
No.
Other
Validation
Reviewer pool: two
sonnetstyle-compliance auditors (split across new packages vs. modifications to existing packages) and twoopusbug scanners. Each was briefed with a per-commit summary of the window so deliberate choices would not be flagged.What was checked:
docs/style-guides/javascript,docs/style-guides/text) against established reference packages of similar shape (e.g.dnanasumfor the new BLAS-ext additions,ndarray/vector/ctorforndarray/matrix/ctor,is-floating-point-data-typefor the newndarray/base/assertpackages).What was deliberately excluded:
The shape-error fix was independently surfaced by three of four reviewers; both docs fixes were single-reviewer findings re-verified directly against the diff before inclusion.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code running as a scheduled review routine: four parallel reviewer agents scanned the last 24 hours of
develop, findings were cross-validated, three were retained, and the fixes (one line each) were applied in this branch. A human maintainer should audit before promoting from draft.Generated by Claude Code