test: add disable_rewards intermittently flow

[arad-starkware]

This change is 

---

Note

Adds RewardSupplier EIC and block duration configuration (with clamped avg block time) and caches per-epoch block rewards in Staking; updates tests and docs accordingly.

• Reward Supplier:
  • EIC & Storage: Introduces RewardSupplierEIC initializing avg_block_duration and BlockDurationConfig with validations.
  • Config API: Adds IRewardSupplierConfig (set_block_duration_config) and view get_block_duration_config; new errors (INVALID_*, etc.).
  • Computation: Clamps computed avg block duration between min_block_duration and max_block_duration; sets sensible defaults.
• Staking:
  • Per-epoch block rewards: Adds last_calculated_epoch and cached block_rewards; calculate_block_rewards now updates/reads per-epoch via update_current_epoch_block_rewards.
  • Consensus init: set_consensus_rewards_first_epoch initializes block rewards and tracking.
• Tests/Utils:
  • Adds flows (multiple BTC pools, empty pools, staker intent, same-epoch idempotence, intermittent disable_rewards).
  • Adds RewardSupplier EIC/config tests; introduces advance_blocks, block-reward calculators, and reward supplier upgrade helpers; replaces direct block advances.
• Docs:
  • Documents get_block_duration_config, set_block_duration_config, BlockDurationConfig, and INVALID_MIN_MAX_BLOCK_DURATION.
• Deps:
  • Bumps starkware-starknet-utils revision.

^{Written by Cursor Bugbot for commit 7670413. This will update automatically on new commits. Configure here.}

[arad-starkware]

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

• test: add update_rewards old delegator flow #94
• test: add update_rewards transition with balance change flow #93
• test: add update_rewards several blocks delegation rewards test #92
• test: add disable_rewards intermittently flow #91 👈 (View in Graphite)
• test: add update_rewards epoch length flow #90
• test: add update_rewards same epoch flow #89
• test: add update_rewards staker intent flow #88 : 1 other dependent PR (#95 )
• test: add update_rewards empty pools flow #87
• test: add update_rewards btc pools flow #86
• noa/staking/v3/rs-eic

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cursor]

Bug: Missing non-zero assertion could mask broken rewards

The test assertion assert!(rewards == expected_rewards) lacks the sanity check assert!(expected_rewards.is_non_zero()) that exists in the similar test update_rewards_disable_rewards_consensus_rewards_flow_test (lines 2880-2881). The test's purpose is to verify that exactly one block's worth of rewards is given when disable_rewards: false is called. Without the non-zero check, if both values were unexpectedly zero due to a bug in the rewards calculation, the equality assertion would still pass, masking a failure in the rewards mechanism.

 

[noa-starkware]

Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @arad-starkware)

---

src/flow_test/test.cairo line 3841 at r2 (raw file):

/// update rewards with disable_rewards = false.
/// Advance block.
/// update rewards with disable_rewards = true.

Can you add one with false again here?