test: add update_rewards same epoch flow#89
Open
arad-starkware wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Nov 27, 2025
ba4450d to
77ea9d3
Compare
89fd67e to
29d31c6
Compare
77ea9d3 to
555b38d
Compare
noa-starkware
requested changes
Nov 27, 2025
noa-starkware
left a comment
Collaborator
There was a problem hiding this comment.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @arad-starkware)
src/flow_test/test.cairo line 3777 at r1 (raw file):
let staker = system.new_staker(amount: stake_amount); let commission = 200; system.stake(:staker, amount: stake_amount, pool_enabled: false, :commission);
Please add strk delegate and btc delegate and test all the rewards
555b38d to
453b967
Compare
3bc8d51 to
8904b34
Compare
8904b34 to
701fb46
Compare
453b967 to
e4e5171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This change is
Note
Adds a test ensuring
update_rewardsyields identical rewards when called twice within the same epoch (even after a block), and updates ideas accordingly.update_rewards_same_epoch_flow_testinsrc/flow_test/test.cairoto assert rewards remain unchanged when callingupdate_rewardstwice in the same epoch, including after advancing one block.src/flow_test/flow_ideas.mdby removing the corresponding test idea underupdate_rewards.calculate_staker_strk_rewards_with_balances_v3call.Written by Cursor Bugbot for commit e4e5171. This will update automatically on new commits. Configure here.