unify secp256k1 api to use just pure-rust libsecp256k1

changelog.d/unified_secp256k1.added

@@ -0,0 +1 @@
+Unified the secp256k1 api to use pure-rust libsecp256k1

clarity/src/vm/tests/crypto.rs

@@ -557,6 +557,28 @@ fn test_secp256k1_verify_valid_signature_returns_true() {
     );
 }
 
+#[test]
+fn test_secp256k1_recover_high_s_signature_succeeds() {
+    // secp256k1-recover? must succeed (return ok) for high-S signatures even though
+    // secp256k1-verify rejects the same signature.
+    let message = "0x89171d7815da4bc1f644665a3234bc99d1680afa0b3285eff4878f4275fbfa89";
+    let signature = "0x54cd3f378a424a3e50ff1c911b7d80cf424e1b86dddecadbcf39077e62fa1e54ee6514347c1608df2c3995e7356f2d60a1fab60878214642134d78cd923ce27a01";
+
+    let program = format!("(is-ok (secp256k1-recover? {message} {signature}))");
+
+    assert_eq!(
+        Value::Bool(true),
+        execute_with_parameters(
+            program.as_str(),
+            ClarityVersion::latest(),
+            StacksEpochId::latest(),
+            false
+        )
+        .expect("execution should succeed")
+        .expect("should return a value")
+    );
+}
+
 #[test]
 fn test_secp256k1_verify_valid_high_s_signature_returns_false() {
     let message = "0x89171d7815da4bc1f644665a3234bc99d1680afa0b3285eff4878f4275fbfa89";

stacks-common/Cargo.toml

@@ -33,6 +33,7 @@ curve25519-dalek = { version = "4.1.3", default-features = false, features = ["s
 ed25519-dalek = { workspace = true }
 hashbrown = { workspace = true }
 lazy_static = { workspace = true }
+libsecp256k1 = { version = "0.7.2", default-features = false, features = ["hmac", "lazy-static-context"] }
 ripemd = { version = "0.1.1", default-features = false }
 serde = { workspace = true , features = ["derive"] }
 serde_derive = { workspace = true }
@@ -62,12 +63,8 @@ winapi = { version = "0.3", features = [
 ], optional = true }
 
 [target.'cfg(not(target_family = "wasm"))'.dependencies]
-secp256k1 = { version = "0.24.3", default-features = false, features = ["std","serde", "recovery"] }
 rusqlite = { workspace = true, optional = true }
 
-[target.'cfg(target_family = "wasm")'.dependencies]
-libsecp256k1 = { version = "0.7.2", default-features = false, features = ["hmac", "lazy-static-context"] }
-
 [target.'cfg(all(any(target_arch = "x86_64", target_arch = "x86", target_arch = "aarch64"), not(any(target_os="windows"))))'.dependencies]
 sha2 = { version = "0.10", features = ["asm"] }
 

stacks-common/src/util/secp256k1/mod.rs

@@ -1,15 +1,6 @@
-#[cfg(not(target_family = "wasm"))]
 mod native;
-
-#[cfg(not(target_family = "wasm"))]
 pub use self::native::*;
 
-#[cfg(target_family = "wasm")]
-mod wasm;
-
-#[cfg(target_family = "wasm")]
-pub use self::wasm::*;
-
 pub const MESSAGE_SIGNATURE_ENCODED_SIZE: u32 = 65;
 
 pub struct MessageSignature(pub [u8; 65]);