unify secp256k1 api to use just pure-rust libsecp256k1#7296
Closed
rob-stacks wants to merge 6 commits into
Closed
Conversation
brice-stacks
requested changes
Jun 10, 2026
| ed25519-dalek = { workspace = true } | ||
| hashbrown = { workspace = true } | ||
| lazy_static = { workspace = true } | ||
| libsecp256k1 = { version = "0.7.2", default-features = false, features = ["hmac", "lazy-static-context"] } |
Contributor
There was a problem hiding this comment.
I believe we should use this one instead: k256. It is more widely accepted and audited.
Contributor
Author
|
Closing this. New PR here: #7305 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This patch unifies the secp256k1 api to only use libsecp256k1 (pure rust).
The same structure is used for wasm.
More unit tests have been added included a new one for checking high-S signatures
Applicable issues
Additional info (benefits, drawbacks, caveats)
Checklist
docs/property-testing.md)changelog.d/README.md)rpc/openapi.yamlfor RPC endpoints,event-dispatcher.mdfor new events)clarity-benchmarkingrepo