Fix multi-ASIC package feature management by william8545 · Pull Request #4445 · sonic-net/sonic-utilities

william8545 · 2026-04-10T18:50:04Z

What I did

Fixed two issues with dynamically installed packages on multi-ASIC platforms:

sonic-package-manager install now writes complete FEATURE entries to all per-ASIC namespace CONFIG_DBs, not just the host CONFIG_DB.
config feature state and config feature autorestart no longer crash with KeyError when per-ASIC FEATURE entries are incomplete.

How I did it

sonic_package_manager/service_creator/sonic_db.py: Added get_namespace_db_connectors() to SonicDB that returns per-ASIC namespace CONFIG_DB connectors on multi-ASIC platforms. get_connectors() now yields these after the host connector, so FeatureRegistry.register() and deregister() write to all CONFIG_DBs.

config/feature.py: Changed entry_data['state'] to entry_data.get('state') in set_feature_state(), and entry_data['auto_restart'] to entry_data.get('auto_restart') in feature_autorestart(). Namespace entries missing the field are skipped during validation. Added a guard for the case where no namespace has the field at all. Fixed the always_enabled check to use the collected set instead of relying on the last loop variable.

How to verify it

On a multi-ASIC system:

sudo sonic-package-manager install xxx

# Verify per-ASIC entries are complete
sonic-db-cli CONFIG_DB HGETALL "FEATURE|xxx"
sonic-db-cli -n asic0 CONFIG_DB HGETALL "FEATURE|xxx"
# Both should show all fields 

# Verify CLI commands work
sudo config feature state xxx enabled
sudo config feature autorestart xxx disabled

# Clean up
sudo sonic-package-manager uninstall xxx -y

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

mssonicbld · 2026-04-10T18:50:13Z

/azp run

azure-pipelines · 2026-04-10T18:50:24Z

Azure Pipelines successfully started running 1 pipeline(s).

Signed-off-by: William Tsai <willtsai@nvidia.com>

mssonicbld · 2026-04-10T19:50:11Z

/azp run

azure-pipelines · 2026-04-10T19:50:22Z

Azure Pipelines successfully started running 1 pipeline(s).

Sourabh-Kumar7 · 2026-05-14T02:04:42Z

@lguohan @abdosi can you pls help review this?

securely1g

Review on behalf of @lguohan:

The fix for multi-ASIC package feature management — please provide:

What specific failure does this address? (The PR description is truncated)
How does this interact with config feature commands on multi-ASIC platforms?
Are there sonic-mgmt tests that validate multi-ASIC feature enable/disable?

william8545 · 2026-05-27T18:25:07Z

Review on behalf of @lguohan:

The fix for multi-ASIC package feature management — please provide:

What specific failure does this address? (The PR description is truncated)

How does this interact with config feature commands on multi-ASIC platforms?

Are there sonic-mgmt tests that validate multi-ASIC feature enable/disable?

Two CLI- and package-manager-side failures after installing a new package

config feature state <pkg> enabled crashes / no-ops. The command prints status and the feature is not enabled.
Host vs ASIC CONFIG_DB divergence after install / uninstall. sonic-package-manager install only populated the host's FEATURE table, so ASIC namespaces never received the row (autorestart and state included). sonic-package-manager uninstall likewise only removed the host row, leaving stale entries in the ASIC namespaces.

config feature state / config feature autorestart iterate db.cfgdb_clients, which utilities_common/db.py::Db builds as {'': host_cfgdb, 'asic0': ..., 'asic1': ..., ...} whenever multi_asic.is_multi_asic() is true. The command (a) validates the entry exists, (b) checks the value is consistent across all namespaces, and (c) writes the new value to every namespace.
No tests in sonic-mgmt that test sonic-package-manager install/uninstall

Sourabh-Kumar7 · 2026-06-09T19:50:25Z

@lguohan @securely1g could you please re-review and approve the changes? Thanks

Copilot

Pull request overview

This PR fixes multi-ASIC handling for dynamically installed package features by ensuring FEATURE table updates are applied across all per-ASIC namespace CONFIG_DB instances, and by hardening config feature commands against incomplete per-namespace FEATURE entries.

Changes:

Extend SonicDB.get_connectors() to include per-ASIC namespace CONFIG_DB connectors on multi-ASIC systems.
Make config feature state and config feature autorestart tolerant of missing state / auto_restart fields across namespaces (avoids KeyError).
Add targeted unit tests for the new SonicDB namespace connector behavior and the CLI/feature validation behavior.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File	Description
tests/sonic_package_manager/test_sonic_db.py	Adds unit tests for per-ASIC namespace connector discovery and connector enumeration behavior.
tests/feature_test.py	Adds tests to cover missing `state` / `auto_restart` fields and expected CLI behavior.
sonic_package_manager/service_creator/sonic_db.py	Adds per-ASIC namespace CONFIG_DB connector support and extends connector iteration to cover namespaces.
config/feature.py	Avoids crashing on incomplete FEATURE entries by using `.get()` and adds guards when fields are missing everywhere.

+        if cls._namespace_db_conns is None:
+            cls._namespace_db_conns = []
+            if device_info.is_multi_npu():
+                from swsscommon.swsscommon import SonicDBConfig
+                SonicDBConfig.initializeGlobalConfig()
+                for ns in device_info.get_namespaces():
+                    try:
+                        conn = swsscommon.ConfigDBConnector(namespace=ns)
+                        conn.connect()
+                        cls._namespace_db_conns.append(conn)
+                    except RuntimeError:
+                        pass
+
+        return cls._namespace_db_conns


mssonicbld · 2026-06-11T19:48:10Z

/azp run

azure-pipelines · 2026-06-11T19:54:20Z

Azure Pipelines successfully started running 1 pipeline(s).

Address the Copilot review on get_namespace_db_connectors(): - Fail fast on a namespace connect error instead of swallowing RuntimeError and returning a partial connector set; a missing namespace CONFIG_DB is a real fault, not something to silently skip. - Cache only after every namespace connects (local accumulator assigned to _namespace_db_conns at the end), so a failed run leaves the cache unset and the next call retries rather than caching a partial list. - Guard the global DB init with isGlobalInit() and call it through the module-level swsscommon import, matching the pattern used in utilities_common/db.py; drop the in-function lazy import. Update tests to cover fail-fast propagation, no-cache-on-failure retry, both isGlobalInit branches, and single/multi-ASIC caching. Signed-off-by: William Tsai <willtsai@nvidia.com>

mssonicbld · 2026-06-12T00:02:17Z

/azp run

azure-pipelines · 2026-06-12T00:02:28Z

Azure Pipelines successfully started running 1 pipeline(s).

william8545 marked this pull request as draft April 10, 2026 18:50

Fix multi-ASIC package feature management

6b7d048

Signed-off-by: William Tsai <willtsai@nvidia.com>

william8545 force-pushed the multi_asic_feature_sync_internal_public branch from c0d677a to 6b7d048 Compare April 10, 2026 19:50

william8545 marked this pull request as ready for review April 10, 2026 22:11

oleksandrivantsiv previously approved these changes Apr 24, 2026

View reviewed changes

securely1g reviewed May 24, 2026

View reviewed changes

Sourabh-Kumar7 requested a review from Copilot June 9, 2026 19:47

Copilot started reviewing on behalf of Sourabh-Kumar7 June 9, 2026 19:47 View session

Copilot AI reviewed Jun 9, 2026

View reviewed changes

william8545 mentioned this pull request Jun 9, 2026

[featured] Fix namespace CONFIG_DBs rendering and cleanup sonic-net/sonic-host-services#373

Open

william8545 dismissed oleksandrivantsiv’s stale review via d14ff99 June 11, 2026 19:27

william8545 force-pushed the multi_asic_feature_sync_internal_public branch from d14ff99 to 9edd74b Compare June 12, 2026 00:02

Conversation

william8545 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Uh oh!

mssonicbld commented Apr 10, 2026

Uh oh!

azure-pipelines Bot commented Apr 10, 2026

Uh oh!

mssonicbld commented Apr 10, 2026

Uh oh!

azure-pipelines Bot commented Apr 10, 2026

Uh oh!

Sourabh-Kumar7 commented May 14, 2026

Uh oh!

securely1g left a comment

Choose a reason for hiding this comment

Uh oh!

william8545 commented May 27, 2026

Uh oh!

Sourabh-Kumar7 commented Jun 9, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

mssonicbld commented Jun 11, 2026

Uh oh!

azure-pipelines Bot commented Jun 11, 2026

Uh oh!

mssonicbld commented Jun 12, 2026

Uh oh!

azure-pipelines Bot commented Jun 12, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

william8545 commented Apr 10, 2026 •

edited

Loading