[featured] Fix namespace CONFIG_DBs rendering and cleanup

[william8545]

What I did

Fixed two issues in featured daemon for multi-ASIC platforms:

1. Feature deregistration now cleans up FEATURE entries from all per-ASIC namespace CONFIG_DBs and STATE_DBs.
2. resync_feature_state() now independently checks each namespace CONFIG_DB for unrendered Jinja2 templates, instead of assuming all namespaces match the host.

How I did it

Deregistration cleanup: In FeatureHandler.handler(), when a feature is deregistered (feature_cfg is empty), added cleanup of the FEATURE entry from all namespace CONFIG_DBs via set_entry(None) and from all namespace STATE_DBs via _del().

Independent namespace rendering: In resync_feature_state(), removed the early return when host state matches the rendered state. The host CONFIG_DB update still only happens for immutable or template states. Added a new loop that independently checks each namespace CONFIG_DB — if a namespace entry still contains a Jinja2 template, it gets rendered to the correct state value regardless of host CONFIG_DB state.

How to verify it

On a multi-ASIC system:

# Test deregistration cleanup
sudo sonic-package-manager install xxx -y
sudo sonic-package-manager uninstall xxx -y --force
# Verify per-ASIC entries are removed
sonic-db-cli -n asic0 CONFIG_DB HGETALL "FEATURE|xxx"
# Should return {}

# Test template rendering
# After boot, check that per-ASIC FEATURE entries have rendered state values
sonic-db-cli -n asic0 CONFIG_DB HGET "FEATURE|xxx" state

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Sourabh-Kumar7]

@abdosi could you pls help with review?

[Copilot]

Pull request overview

This PR fixes multi-ASIC behavior in the featured host daemon by ensuring feature deregistration fully cleans up per-namespace databases, and by making template rendering/resync logic operate independently per namespace rather than assuming host and namespace CONFIG_DB entries are aligned.

Changes:

• On feature deregistration, remove FEATURE|<name> from all namespace CONFIG_DBs and STATE_DBs.
• Update resync_feature_state() to always check each namespace CONFIG_DB for template values and render them even when the host CONFIG_DB already matches the rendered state.
• Add unit tests covering namespace cleanup on deregistration and namespace-only template rendering behavior.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File	Description
tests/featured/featured_test.py	Adds unit tests for namespace cleanup during deregistration and namespace template rendering in resync_feature_state().
scripts/featured	Implements namespace cleanup on deregistration and independent namespace template rendering/resync logic.

[william8545]

fix

[qiluo-msft]

None of the four patched methods are reachable, so the decorators are dead weight that makes the test noisier than it needs to be. Drop them.

[william8545]

fix

[mssonicbld]

/azp run

[azure-pipelines]

Azure Pipelines successfully started running 1 pipeline(s).

[Sourabh-Kumar7]

@abdosi @qiluo-msft could you please help re-review the change?

[abdosi]

what is reason for making this change ?

[william8545]

what is reason for making this change ?

This is the featured-daemon half of a two-part fix for multi-ASIC platforms, where per-ASIC namespace FEATURE state diverged from the host for dynamically installed packages — config feature state enabled failed, and uninstall left stale entries in the ASIC namespaces. The package-manager/CLI half is here: sonic-net/sonic-utilities#4445 featured subscribes only to the host CONFIG_DB and is what propagates state into the namespaces, so three things can only be done here:

1. STATE_DB cleanup on deregister
2. Independent per-namespace rendering in resync_feature_state()
3. Resync on (re-)registration