Skip to content

Stop using sys.args logic in test#1719

Merged
ddoktorski merged 2 commits into
developmentfrom
ddoktorski/stop-using-sys-args
May 7, 2026
Merged

Stop using sys.args logic in test#1719
ddoktorski merged 2 commits into
developmentfrom
ddoktorski/stop-using-sys-args

Conversation

@ddoktorski

Copy link
Copy Markdown
Collaborator

Towards #1698

  • sys.args logic is unereliable when tests are run on multiple workers using pytest-xdist, each worker executes a separate command which doesn't include intiial --contract_dir value. To fix this we set global _contract_dir variable that is executed before running tests

@ddoktorski

ddoktorski commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

Comment thread starknet_py/tests/e2e/docs/quickstart/test_using_account.py
Base automatically changed from ddoktorski/fix-load-config to development May 7, 2026 08:00
@ddoktorski ddoktorski force-pushed the ddoktorski/stop-using-sys-args branch from dc9145c to b330b9d Compare May 7, 2026 08:01
@ddoktorski ddoktorski merged commit 9e64bfd into development May 7, 2026
12 of 20 checks passed
@ddoktorski ddoktorski deleted the ddoktorski/stop-using-sys-args branch May 7, 2026 08:09
@ddoktorski ddoktorski mentioned this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants