Skip to content

Add explicit package in load_contract calls#1718

Merged
ddoktorski merged 1 commit into
developmentfrom
ddoktorski/fix-load-config
May 7, 2026
Merged

Add explicit package in load_contract calls#1718
ddoktorski merged 1 commit into
developmentfrom
ddoktorski/fix-load-config

Conversation

@ddoktorski

Copy link
Copy Markdown
Collaborator

Towards #1698

  • Add explicit package= in load_contract calls where possible, especially for contracts that only exists in v2 directory to avoid relying on default behavior

@ddoktorski

ddoktorski commented Apr 30, 2026

Copy link
Copy Markdown
Collaborator Author

@franciszekjob franciszekjob left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we always explicitly passing package in the function call? If so, do we want to keep package param optional at all?

@ddoktorski

Copy link
Copy Markdown
Collaborator Author

Are we always explicitly passing package in the function call? If so, do we want to keep package param optional at all?

Not always, e.g. https://github.com/software-mansion/starknet.py/blob/ddoktorski/fix-load-config/starknet_py/tests/e2e/contract_interaction/declare_test.py#L39

@ddoktorski ddoktorski requested a review from franciszekjob May 6, 2026 13:04
@ddoktorski ddoktorski merged commit 26418ac into development May 7, 2026
12 checks passed
@ddoktorski ddoktorski deleted the ddoktorski/fix-load-config branch May 7, 2026 08:00
@ddoktorski ddoktorski mentioned this pull request May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants