Repository navigation
fix(settings): stop the dialog growing on every header click - #950
Merged
PathGao merged 1 commit intoOct 1, 2026
Merged
Conversation
Collaborator
|
好神奇的bug |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this is
The settings dialog grew 2px at a time, every time its header was clicked — down and to the right, until the viewport clamp caught it. Dragging the header or a resize handle did the same, once per gesture. I could not find an upstream issue for it; it turned up by hand while using the dialog.
One declaration fixes it:
.settings-modalisbox-sizing: border-boxnow.Clicks on the header, no dragging:
bug.mp4