Skip to content

fix: use default checkout ref and enable yaml ci#35

Closed
G36maid wants to merge 7 commits into
mainfrom
fix/checkout-behavior
Closed

fix: use default checkout ref and enable yaml ci#35
G36maid wants to merge 7 commits into
mainfrom
fix/checkout-behavior

Conversation

@G36maid

@G36maid G36maid commented Feb 1, 2026

Copy link
Copy Markdown
Contributor
  1. Remove explicit ref: ${{ github.head_ref }} from reusable workflows. This ensures CI runs against the merge commit (default behavior) to catch integration issues.

  2. Enable run-config-checks in main.yml to validate this repository's own configuration files (dogfooding).

Closes #34

目的

{{請敘述這支 PR 的目的,例如解決了什麼問題、改善了什麼功能或新增了什麼特性}}

方法/實作說明

{{請描述你完成目的的方法,包括技術重點、修改的檔案、主要邏輯}}

  • 主要修改:
    • {{列出重要變更的模組或檔案}}
  • 關鍵實作:
    • {{描述主要邏輯或技術手段(例如使用 debounce 優化輸入效能)}}

關聯 Issue

{{若此 PR 相關 issue,請連結,例如:Closes #123, Fixes #456}}

附註

{{請列出額外說明,如尚未完成部分、後續計劃或 TODO 項目}}

  • TODO:
    • {{描述後續要補上的功能或測試}}

@G36maid G36maid changed the title ci: use default checkout ref and enable yaml ci fix: use default checkout ref and enable yaml ci Feb 1, 2026
1. Remove explicit `ref: ${{ github.head_ref }}` from reusable
   workflows. This ensures CI runs against the merge commit (default
   behavior) to catch integration issues.

2. Enable `run-config-checks` in `main.yml` to validate this
   repository's own configuration files (dogfooding).

Closes #34
@G36maid G36maid force-pushed the fix/checkout-behavior branch from d332b4f to 792fe76 Compare February 1, 2026 18:09
- Replace direct script execution with composite actions
- basic-checks: 4 jobs → 1 job (basic-checks)
- config-checks: 3 jobs → 1 job (config-checks)
- frontend-checks: 2 jobs → 1 job (frontend-checks)
- python-checks: inline execution → 1 job (python-checks)

All output keys preserved for entrypoint.yml compatibility
Removed 11 scripts that have been migrated to composite actions:
- check-pr-title.sh, check-branch-name.sh (→ basic-checks/)
- check-commit-messages.sh, check-conflicts.sh (→ basic-checks/)
- check-yaml-files.sh, check-json-files.sh, check-toml-files.sh (→ config-checks/)
- check-prettier.sh, parse-eslint-json.sh (→ frontend-checks/)
- setup-pyproject.sh, parse-mypy-output.sh (→ python-checks/)

go-check-outcome.sh retained for Go checks (reusables-go.yml)

del
- Create basic-checks composite action with 4 scripts
- Create config-checks composite action with 3 scripts
- Create frontend-checks composite action with 2 scripts
- Create python-checks composite action with 2 scripts

Each action uses ${{ github.action_path }} for reliable path resolution
- Add architecture section showing 4 composite actions
- Include usage examples for individual actions
- Replace old script-based documentation with new structure
@github-actions

github-actions Bot commented Feb 1, 2026

Copy link
Copy Markdown

🛡️ PR Quality Check Summary

⚠️ PR Title: No output received
⚠️ Branch Name: No output received
⚠️ Commit Messages: No output received
⚠️ Conflicts: No output received
⚠️ YAML Files: No output received
⚠️ JSON Files: No output received
⚠️ TOML Files: No output received


🎉 All checks passed!

Point quality-checks at ./.github/workflows/entrypoint.yml
instead of the external org repository. Add YAML document start marker
(---) and tidy spacing in reusables-go.yml
@G36maid G36maid marked this pull request as draft February 1, 2026 19:48
@G36maid

G36maid commented Feb 1, 2026

Copy link
Copy Markdown
Contributor Author

Duplicate of #36

@G36maid G36maid marked this as a duplicate of #36 Feb 1, 2026
@G36maid G36maid closed this Feb 1, 2026
@G36maid G36maid deleted the fix/checkout-behavior branch February 1, 2026 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix checkout behavior to use merge commit & enable self-repository config checks

1 participant