fix: use default checkout ref and enable yaml ci#35
Closed
G36maid wants to merge 7 commits into
Closed
Conversation
1. Remove explicit `ref: ${{ github.head_ref }}` from reusable
workflows. This ensures CI runs against the merge commit (default
behavior) to catch integration issues.
2. Enable `run-config-checks` in `main.yml` to validate this
repository's own configuration files (dogfooding).
Closes #34
d332b4f to
792fe76
Compare
- Replace direct script execution with composite actions - basic-checks: 4 jobs → 1 job (basic-checks) - config-checks: 3 jobs → 1 job (config-checks) - frontend-checks: 2 jobs → 1 job (frontend-checks) - python-checks: inline execution → 1 job (python-checks) All output keys preserved for entrypoint.yml compatibility
Removed 11 scripts that have been migrated to composite actions: - check-pr-title.sh, check-branch-name.sh (→ basic-checks/) - check-commit-messages.sh, check-conflicts.sh (→ basic-checks/) - check-yaml-files.sh, check-json-files.sh, check-toml-files.sh (→ config-checks/) - check-prettier.sh, parse-eslint-json.sh (→ frontend-checks/) - setup-pyproject.sh, parse-mypy-output.sh (→ python-checks/) go-check-outcome.sh retained for Go checks (reusables-go.yml) del
…ns in reusables-go.yml
- Create basic-checks composite action with 4 scripts
- Create config-checks composite action with 3 scripts
- Create frontend-checks composite action with 2 scripts
- Create python-checks composite action with 2 scripts
Each action uses ${{ github.action_path }} for reliable path resolution
- Add architecture section showing 4 composite actions - Include usage examples for individual actions - Replace old script-based documentation with new structure
🛡️ PR Quality Check Summary
🎉 All checks passed! |
Point quality-checks at ./.github/workflows/entrypoint.yml instead of the external org repository. Add YAML document start marker (---) and tidy spacing in reusables-go.yml
Contributor
Author
|
Duplicate of #36 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove explicit
ref: ${{ github.head_ref }}from reusable workflows. This ensures CI runs against the merge commit (default behavior) to catch integration issues.Enable
run-config-checksinmain.ymlto validate this repository's own configuration files (dogfooding).Closes #34
目的
{{請敘述這支 PR 的目的,例如解決了什麼問題、改善了什麼功能或新增了什麼特性}}
方法/實作說明
{{請描述你完成目的的方法,包括技術重點、修改的檔案、主要邏輯}}
關聯 Issue
{{若此 PR 相關 issue,請連結,例如:Closes #123, Fixes #456}}
附註
{{請列出額外說明,如尚未完成部分、後續計劃或 TODO 項目}}