Repository navigation
Parts build: configure the inserted feature by its id; redo the WCP release as v1.1.1 - #29
Merged
Merged
Conversation
…pe lists it The build found the feature to configure by its type in the feature list read after the insert. The v1.1.0 release's Nut was refused with a 404 "Feature not found", as though that read still named the feature the build had just deleted. It now configures the feature by the id the insert answered, reading the list again a second apart until it shows it, and stops with an error after five reads rather than configure another. v1.1.0 ran partway (its backend version, fasteners.fs and Screw in FRCDesignLib), so its release file is replaced by one asking for v1.1.1, which does the whole release again. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4daFKz4qvNwCEYcg38VKS
git log's rename detection otherwise reports it as renamed, not added, so its marker named no commit. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4daFKz4qvNwCEYcg38VKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v1.1.0 release from #28 ran partway. It made the backend version, pointed FRCDesignLib's
fasteners.fsat it and rebuiltScrew. Then Onshape refused to configure the newly insertedfastenerNutinNutwith a 404 "Feature not found". Your Screw (TEST) build hit the same error earlier.The cause
The build found the feature to configure by its type, in a feature list read right after the insert. The 404 suggests that read still listed the feature the build had just deleted. That's inferred, not confirmed.
The fix
Release
v1.1.0 can't be retried: its backend version carries the release file's marker.
releases/fasteners.tomlis therefore replaced byreleases/fasteners-wcp-lengths.toml, a patch release. Merging this makesFasteners - v1.1.1and runs the whole release again.added_inalso ignores renames now. Otherwise a release file renamed from another would carry no commit in its marker.uv run pytest -q: 944 passed.fs releasespasses.Generated by Claude Code