Repository navigation
fs push: commit the import versions it takes, even with nothing to push - #30
Merged
Merged
Conversation
…nothing to push It wrote them into the local files but committed only alongside a push, so fs sync-main with nothing to push left fasteners.fs changed, and fs run-releases refused the dirty tree before making v1.1.1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4daFKz4qvNwCEYcg38VKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Onshape run for #29 stopped before making the v1.1.1 release.
fs sync-mainupdatedfasteners/fasteners.fswith Onshape's import versions. It found nothing else to push, so it didn't commit, becausecommit_pushedonly commits alongside a push or a delete.fs run-releasesthen refused the dirty tree: "Commit or stash your changes first". Nothing was released.commit_pushednow also commits import versions taken on their own, as "Take import versions from Onshape". A new test pushes with nothing to push after Onshape changed an import version, and checks that the tree is left clean. It failed before this fix.uv run pytest -q: 945 passed.releases/fasteners-wcp-lengths.tomlis still pending, so merging this runs the v1.1.1 release.Generated by Claude Code