Repository navigation
Release files: mark a release with the commit that added its file - #28
Merged
Merged
Conversation
The marker ending a release's version descriptions was the file's name alone, so a file reusing a released file's name, as releases/fasteners.toml did for v1.1.0, was taken for the earlier release and stopped fs run-releases before it made anything. It now names the commit that added the file too: a retry of the same file is still found, and a later file of the same name releases. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01T4daFKz4qvNwCEYcg38VKS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Fasteners v1.1.0 release from #27 never ran.
fs run-releasesstopped with "fasteners.toml already made Fasteners - v1.0.0" before making anything. The cause: the marker that ends each release's version descriptions was just the file name,[releases/fasteners.toml], and v1.0.0's release used the same name. Main itself landed in Onshape fine.The marker now also names the commit that added the file:
[releases/fasteners.toml ad9171e650a2].The test checks both cases.
docs/fs-cli.mddescribes the new marker.uv run pytest -q: 943 passed.Merging this runs the Onshape workflow again.
releases/fasteners.tomlis still pending on main, so the run makesFasteners - v1.1.0in the backend and rebuilds FRCDesignLib's Part Studios. FRCDesignLib's document is not versioned.Generated by Claude Code