Skip to content

Also add convenience property for checking whether it is successful #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rklec wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Also add convenience property for checking whether it is successful #16

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4815634
Also add convenience property for checking whether it is successful
rklec Sep 24, 2024
89f2af8
Make isSoft/IsHard mutually exclusive with IsSucess for logical reasons
rklec Sep 24, 2024
b1a2c1d
Fix actually properly accessing the primary status
rklec Sep 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions MailBounceDetector/BounceDetectResult.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -190,8 +190,9 @@ MimeEntity undeliveredMessagePart
}

public bool IsBounce => DeliveryStatus != null;
public bool IsHard => IsBounce && PrimaryStatus != null && PrimaryStatus.Code > 4;
public bool IsSoft => IsBounce && PrimaryStatus != null && PrimaryStatus.Code <= 4;
public bool IsHard => IsBounce && !IsSuccess && PrimaryStatus != null && PrimaryStatus.Code > 4;
public bool IsSoft => IsBounce && !IsSuccess && PrimaryStatus != null && PrimaryStatus.Code <= 4;
public bool IsSuccess => IsBounce && PrimaryStatus.Code == 4;
public BounceStatus PrimaryStatus { get; }
public BounceStatus SecundaryStatus { get; }
public BounceStatus CombinedStatus { get; }
Expand Down