Also add convenience property for checking whether it is successful#16
Open
rklec wants to merge 3 commits into
Open
Also add convenience property for checking whether it is successful#16rklec wants to merge 3 commits into
rklec wants to merge 3 commits into
Conversation
It may be useful to have that, because otherwise `IsSoft` Maybe also make `IsSoft` exclusive, as a successful status notification obviously is not a "soft" (failure) nor "hard" (failure), but no failure at all.
As explained in rgl#16 > a successful status notification obviously is not a "soft" (failure) nor "hard" (failure), but no failure at all. Also made the same for `IsHard` even though it is logically not needed, but it looks better and for the human it is not easily understandable otherwise why `IsHard` does not have such a check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It may be useful to have that, because otherwise
IsSoftreturns true, which makes no sense.Maybe also make
IsSoftexclusive, as a successful status notification obviously is not a "soft" (failure) nor "hard" (failure), but no failure at all.