Skip to content

refactor(webapi): isolate DOMTree and core CSS features [Codex] - #415

Merged
jderochervlk merged 10 commits into
mainfrom
feat/core-dom-element-types
Nov 17, 2026
Merged

jderochervlk merged 10 commits into
mainfrom
feat/core-dom-element-types

Conversation

@jderochervlk

@jderochervlk jderochervlk commented Nov 16, 2026 •

Copy link
Copy Markdown
Collaborator

Stacked on #413. This replaces the earlier six-module consolidation with selective feature boundaries.

Keep basic DOM.res and seven CSS declaration modules byte-for-byte unchanged from the History/Location baseline. Add WebAPI.DOMTree for the existing rich tree records and WebAPI.CSSOMCore for the CSS modules those records need. DOMNodes and CSSOM continue to include their required features, preserving their existing public APIs.

Move DOMStringMap alongside DOMTree and move only the small generic HTMLCollection representation into DOMTree, retaining the public collection alias and methods. CSS modules keep their original records and operations together rather than introducing a large shared-record layer. The existing fields, generic parameters, privacy, constructors, and runtime behavior are preserved; all 338 existing modules emit identical JavaScript to baseline.

React can select WebAPI.DOMTree, WebAPI.History, and WebAPI.Location: 15 WebAPI source modules rather than 59. The controlled comparison recorded a 122.27 ms median clean React build, effectively tied with the earlier six-module version's 121.48 ms, without enlarging basic DOM. The original 59-module selection measured 196.98 ms in that sample. Timings have substantial variance and are not a universal performance guarantee.

The seven CSS modules' operations are intentionally included in CSSOMCore. Element, Node, HTMLCollection, Event, geometry, Animation, Window, and Document operations still require their respective features. CSSOM does not select DOMTree.

The dependent React migration, full raw measurements, consumer costs, and reproduction details are in jderochervlk/rescript-react#1. Its separate JsxDOM removal is jderochervlk/rescript-react#2. Style-input and synthetic-event ownership changes remain outside this PR.

@jderochervlk jderochervlk changed the title refactor(webapi): move shared element types into core DOM [Codex] refactor(webapi): isolate DOMTree and core CSS features [Codex] Nov 17, 2026
@jderochervlk
jderochervlk marked this pull request as ready for review November 17, 2026 00:34
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T12:53:58.061707Z 13a0ac9 New commits
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

jderochervlk added a commit that referenced this pull request Nov 17, 2026
React's DOM bindings need element, history, and location types, but
History and Location currently belong to the Window feature. Selecting
those types therefore also compiles the broader Window dependency graph.

Add independent `WebAPI.History` and `WebAPI.Location` features and move
their source files into their own directories. History depends only on
the standard library; Location depends on core DOM. Window includes both
features, preserving existing module names and type identities.

Consumers can select `WebAPI.DOMNodes`, `WebAPI.History`, and
`WebAPI.Location` without enabling Window. The feature-ownership checks
register both new source groups and guard missing features and duplicate
public-module ownership. The API guide documents the narrower selection.

The compiler upgrade has already landed in #414. This branch now
incorporates that main-branch update and retains its compiler checks,
documentation renderer, and typed-array fixture. The remaining diff is
limited to the History/Location feature split, its documentation, and
feature validation.

The further selective DOMTree/CSS layout is separate in #415; the React
profiling and dependent JSX work remain in
jderochervlk/rescript-react#1 and
jderochervlk/rescript-react#2.
Base automatically changed from feat/isolate-history-location to main November 17, 2026 11:35
React bindings need clipboard data, touch lists, and FormData types
without enabling the complete UIEvents and Fetch groups. Add four
independently selectable features while retaining the existing broad
features as compatibility umbrellas.

- **WebAPI.Touch** owns Touch and TouchList and depends only on DOM.
- **WebAPI.FormData** owns FormData and its unboxed entry-value union
and depends only on DOM.
- **WebAPI.FileEntries** moves the five existing legacy file-entry
modules intact, preserving the API needed by `webkitGetAsEntry` without
pulling in streams or modern filesystem handles.
- **WebAPI.DataTransfer** owns the transfer/item/list modules and
includes DOMTree and FileEntries, preserving `setDragImage` and
`webkitGetAsEntry` at their existing public paths.

Small representations now belong to the existing public API modules.
UiEventsTypes and FetchTypes retain representation/constructor
re-exports; file/blob signatures use their equal DOM types. Basic DOM is
unchanged. This adds no backing-holder modules and keeps existing public
operation names, privacy, nullability, and unboxed representations.

### Narrow dependency selection

With DOMTree + History + Location, adding Touch + DataTransfer +
FormData compiles **27 WebAPI source modules**, versus **102** with
broad UIEvents + Fetch. Standalone Touch and FormData each compile five
sources including DOM. These are compiler-inventory counts, not
build-speed claims. FileList operations remain an explicit broader File
opt-in; the optional separate FileList feature is not included.

The change includes narrow and packed-consumer fixtures, excluded-module
checks, source-inventory assertions, legacy type/constructor
interoperability, and native form-data/transfer/touch coverage. It does
not replace React's boxed form-value variant with WebAPI's unboxed
union.

### Prerequisite

Stacked on
#415.
The new branch was created from current `origin/main` at `20d11da1`
(including merged #413), then merged #415's prerequisite changes. This
PR targets #415's branch to keep its review diff limited to the
data-feature split; retarget to main after #415 merges.

Follow-on consumers are
jderochervlk/rescript-react#1 and
jderochervlk/rescript-react#2. Existing
profiling results are not measurements of this new integration.
@jderochervlk
jderochervlk merged commit b04c358 into main Nov 17, 2026
4 checks passed
@jderochervlk
jderochervlk deleted the feat/core-dom-element-types branch November 17, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants