Repository navigation
feat(webapi): isolate narrow touch and form data features [Codex] - #416
Conversation
React's DOM bindings need element, history, and location types, but History and Location currently belong to the Window feature. Selecting those types therefore also compiles the broader Window dependency graph. Add independent `WebAPI.History` and `WebAPI.Location` features and move their source files into their own directories. History depends only on the standard library; Location depends on core DOM. Window includes both features, preserving existing module names and type identities. Consumers can select `WebAPI.DOMNodes`, `WebAPI.History`, and `WebAPI.Location` without enabling Window. The feature-ownership checks register both new source groups and guard missing features and duplicate public-module ownership. The API guide documents the narrower selection. The compiler upgrade has already landed in #414. This branch now incorporates that main-branch update and retains its compiler checks, documentation renderer, and typed-array fixture. The remaining diff is limited to the History/Location feature split, its documentation, and feature validation. The further selective DOMTree/CSS layout is separate in #415; the React profiling and dependent JSX work remain in jderochervlk/rescript-react#1 and jderochervlk/rescript-react#2.
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Subagent review completed against final head Local validation passed: all 36 feature builds and narrow inventories, packed consumers and negative fixtures, runtime tests, all four Chromium tests, documentation build/link checks, and formatting. The review also covered the corrected fixtures: alpha.7 already accepts an empty record for the declared private FormData type, and programmatically created DataTransfer objects ignore drag-effect changes outside a native drag session. Both limitations are documented rather than treated as new binding defects. |
React bindings need clipboard data, touch lists, and FormData types without enabling the complete UIEvents and Fetch groups. Add four independently selectable features while retaining the existing broad features as compatibility umbrellas.
webkitGetAsEntrywithout pulling in streams or modern filesystem handles.setDragImageandwebkitGetAsEntryat their existing public paths.Small representations now belong to the existing public API modules. UiEventsTypes and FetchTypes retain representation/constructor re-exports; file/blob signatures use their equal DOM types. Basic DOM is unchanged. This adds no backing-holder modules and keeps existing public operation names, privacy, nullability, and unboxed representations.
Narrow dependency selection
With DOMTree + History + Location, adding Touch + DataTransfer + FormData compiles 27 WebAPI source modules, versus 102 with broad UIEvents + Fetch. Standalone Touch and FormData each compile five sources including DOM. These are compiler-inventory counts, not build-speed claims. FileList operations remain an explicit broader File opt-in; the optional separate FileList feature is not included.
The change includes narrow and packed-consumer fixtures, excluded-module checks, source-inventory assertions, legacy type/constructor interoperability, and native form-data/transfer/touch coverage. It does not replace React's boxed form-value variant with WebAPI's unboxed union.
Prerequisite
Stacked on #415. The new branch was created from current
origin/mainat20d11da1(including merged #413), then merged #415's prerequisite changes. This PR targets #415's branch to keep its review diff limited to the data-feature split; retarget to main after #415 merges.Follow-on consumers are jderochervlk/rescript-react#1 and jderochervlk/rescript-react#2. Existing profiling results are not measurements of this new integration.