DOC-7128 embeds-oss: convert embeds/ and oss_and_stack/ images - #4189
Merged
Merged
Conversation
Runs build/migrate_image_shortcodes.py over content/embeds/ and content/operate/oss_and_stack/, converting 89 image shortcodes to Markdown images. 21 that the codemod can't convert safely stay as shortcodes. Embeds render inside every page that includes them, including archived version pages, so the build comparison checked them through those pages: no image attributes changed anywhere except the moved images. The 7 Triggers and Functions screenshots used by Quick_Start_RI.md lived in a content/ images/ folder, which the codemod won't convert. They move to static/images/triggers-and-functions/, as polygons.png did in #4152. The files are byte-identical, nothing else referenced them, and the old URLs stop being published. Four embeds are dead: content/embeds/ never renders as pages (build: render: never), and nothing includes account-role-table.html, rc-create-db-use-cases.md, rc-version-upgrade.md, or tls-configuration-procedure.md. Three of those are converted here but can't be render-verified. account-role-table.html's 36 raw <img> tags with ../ paths are left alone, because they never render. Gaps: the converted dead embeds (rc-create-db-use-cases, rc-version-upgrade, tls-configuration-procedure) could not be render-verified Ticket: DOC-7128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Contributor
🧠 Redis MemoryFound 5 related items from repository history (5 new this commit):
Memory updated at fca8e94 |
Contributor
This was referenced Oct 2, 2026
andy-stark-redis
added a commit
that referenced
this pull request
Oct 2, 2026
…plit the april-2025 toggles) The hook now marks an image img-inline only when it's inline, local, AND carries #no-click. Before, any local image sharing a paragraph with text qualified, so a future screenshot written directly under a line of text, with no blank line, would have silently shrunk to text height. Every converted icon already has #no-click, so none of them change. The light and dark mode toggles in rc/changelog/april-2025.md were a paragraph of their own, joined by , so the codemod treated the pair as inline icons and they dropped from 149x57 to about 63x24. They're now two standalone images separated by a blank line, back at their natural size. The had to go too: an image followed by isn't alone in its paragraph, so it would have stayed inline. As block images they stack rather than sit side by side. Merged main first, which brings in #4189's conversion of the tls-configuration-procedure.md screenshot the review asked about. Learned: an image that ends its line with isn't alone in its paragraph, so a blank line alone won't make it a block image Constraint: render-image.html adds img-inline only to inline, local, #no-click images; a screenshot sharing a paragraph with text must stay full size Ticket: DOC-7128 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 2, 2026
EliShteinman
added a commit
to EliShteinman/docs
that referenced
this pull request
Oct 3, 2026
Converts the embeds and oss_and_stack image shortcodes to Markdown images and moves the Triggers and Functions screenshots to static/images. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts the
imageshortcodes incontent/embeds/andcontent/operate/oss_and_stack/to Markdown images, using the codemod from #4151. Part of DOC-7128.Counts: 89 images converted in 35 files. 21 shortcodes stay as shortcodes, because the codemod can't convert them safely. Most are in
rs-observability.mdandtls-configuration-procedure.md, where an image follows a list step with no blank line in between, so it shares a paragraph with the text. There's also one inline icon, plus a timeseries table line holding two images.Moved images: the 7 Triggers and Functions screenshots used by
Quick_Start_RI.mdlived in animages/folder undercontent/, which the codemod won't convert. They move tostatic/images/triggers-and-functions/, aspolygons.pngdid in #4152. Nothing else referenced them, and their old URLs stop being published.Embeds: an embed renders inside every page that includes it, including archived version pages. So the build comparison checked the converted embeds through those pages.
Dead embed files (flagged, not deleted):
content/embeds/never renders as pages of its own (build: render: never), and these four aren't included anywhere:account-role-table.html,rc-create-db-use-cases.md,rc-version-upgrade.md, andtls-configuration-procedure.md. The last three are converted here, but can't be render-verified.account-role-table.htmlhas 36 raw<img>tags with../paths, and I've left them alone because they never render. All four look like candidates for deletion in a separate change.Verification
mainand this branch under the production baseURL (/docs/latest/): both succeeded (19,664 pages), and the hook reported no missing images.src/width/alt/classfor every image on every page. The only differences are the 7 moved images'srcpaths. I checked those files: they're byte-identical to the originals, and published at their new URLs.oss_and_stack/has 43 source shortcodes, and all 43 render onmain, so the comparison saw every one. Site-wide, renderedsdata-lightboxwrappers drop from 691 to 450, because each converted embed renders on every page that includes it./images/links. Absolute image URLs go from 2,081 to 2,088, which is the 7 moved images now under/images/.🤖 Generated with Claude Code
Note
Low Risk
Documentation-only markup and static asset path changes; no application, auth, or data-handling code is affected.
Overview
Replaces Hugo
{{< image >}}shortcodes with standard Markdown images acrosscontent/embeds/andcontent/operate/oss_and_stack/(89 conversions in 35 files), using absolute/images/...paths and movingwidth,class, and similar options to attribute lines on the line after the image where the codemod supports it.Triggers and Functions screenshots referenced by
Quick_Start_RI.mdare relocated from undercontent/tostatic/images/triggers-and-functions/, with markdownsrcupdated accordingly. 21 shortcodes are intentionally unchanged (e.g. inline UI icons intls-configuration-procedure.md, many dashboard images still shortcoded inrs-observability.md).No product or API behavior changes—this is a docs build/markdown migration aligned with prior codemod work (#4151).
Reviewed by Cursor Bugbot for commit fca8e94. Bugbot is set up for automated code reviews on this repo. Configure here.