Introduce structured completion sources and cancellable native capture - #233
Open
raiseCatError wants to merge 1 commit into
Open
raiseCatError wants to merge 1 commit into
raiseCatError wants to merge 1 commit into
Conversation
This was referenced Sep 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Native completion now produces source-independent candidates with replacement values/ranges, buffer/cwd context, display text, descriptions, kind and source. The existing zsh capture helper and full-buffer insertion behavior remain the source and compatibility contract; no configured-zsh parity is claimed. Future engines can implement CompletionSource without coupling the composer to their output format.
Completion requests cancel superseded work and discard late results even from sources that ignore abort. The shared external runner accepts AbortSignal while retaining detached process-group isolation, timeout and output bounds; app shutdown cancels active capture work.
Depends on #193; base is tooling/155-performance-benchmarks. Merge order: #193, then this PR. Do not merge during milestone development.
Validation: build/typecheck/diff check, model and real provider-abort tests, full suite (inherited NO_COLOR removed). Physical QA: ordinary native completion and rapid edits; richer menu integration follows in #141. Existing native insertion limitations for complex quoting remain; this PR preserves that behavior.
Refs #140