Fix playback, deletion, cache reuse, and recording recovery - #1751
Merged
Merged
Conversation
This was referenced Sep 22, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Six focused repairs to existing behavior, with reproduced regressions and independent review:
No language selector, CLI, device picker, playback-regeneration feature, audio-only backend migration, or version/release metadata change is included. The existing audio-only/plus-menu work remains separate.
Verification
The first full Core run found a test-oracle path alias (
/varversus/private/var) in the new repeated-speaker-review test. Both URL sides now resolve symlinks while preserving the exact single-file assertion; the focused regression and full rerun passed. Identity, original date/time and byte-idempotence assertions remain intact.The local-log warning predates this candidate. It is a warning/error-line frequency, not a recording failure rate; it was investigated rather than cleared or suppressed.
Independent review
An independent agent reviewed the full production diff against main
5785b52b9a72ea8302c3304ea3ddf68c1b6a6482, including the new support dispatcher: no actionable findings remained. A follow-up independent review covered the final test-oracle correction and real-Core deletion harness: no actionable findings. No findings were silently dismissed. Codex coordinated and reviewed; other model lanes were skipped for this bounded Swift repair/test work.Remaining proof / release boundary
This PR is an implemented and locally verified repair batch, not a release approval. No customer communication or distribution surfaces were changed.