Add meeting language picker and automatic Whisper language detection - #1752
Merged
Merged
Conversation
The recording-end tail drop in the Core Audio tap change is fixed in 4765e68: stop arms the attempt's tail admission before the recording generation advances, finishes and drains the backend instead of cancelling it, and AudioStopCleanup closes the system writer on the same serial file queue behind the drained writes. Nothing pinned that wiring. CoreAudioSystemAudioCaptureTests covers the backend drain and the admission window in isolation, but no test exercised Audio.stop's ordering, and no CI job records real audio, so moving either line would silently truncate the end of every saved meeting. Add SystemAudioStopTailHandoffTests: an end-to-end pass through the real AudioStopCleanup scheduler asserting a queued ring tail reaches the WAV before the writer closes, the cancellation counterpart asserting a superseded attempt still discards its tail, and a source-order contract for the two orderings inside Audio.stop that no unit test can observe. Also correct the stale "Deferred P2" bullet in the probe README, which still described the tail drop as unresolved. No production code changes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NwYbJHm2aXJogYcYKEps2s
This was referenced Sep 22, 2026
r3dbars
changed the base branch from
codex/audio-release-verification
to
main
September 22, 2026 11:35
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stack / merge boundary
This is a draft feature PR, not release approval. Its base is the frozen combined verification snapshot
codex/audio-release-verificationata2011b07ddc098ec2acf1a4f215cd21cfd17d92f.That snapshot combines work already tracked in #1747 (audio-only permissions and Meetings creation menu), #1749 (stop-tail regression coverage), and #1751 (existing-functionality fixes). Using it as the base keeps this diff limited to the two new feature/fix commits instead of duplicating all three dependency PRs.
Do not merge this into the integration snapshot as a substitute for shipping. Land/reconcile those dependency PRs first, then rebase/retarget this PR to
mainand rerun the relevant gates. No dependency PR is merged by this change.Verification completed
.agent-review/visuals/transcription-language/.fi / explicit / fi, then Auto →auto / detected / fi. Each saved 73 words / 5 system utterances. No reference transcript was used, so this is functional language/detection proof, not a measured accuracy score.automaticUncertainand successfully fell back to per-segment Auto. Do not describe that run as a confident recording-wide language lock.Independent review
[fi, fi, nil] → uncertainregression.Remaining release acceptance
Raw recordings, transcript contents, private logs, and customer data remain local. Nothing has been merged, released, or emailed.