doctrine: scan all use_cases dirs, not just top-level#119
Merged
Conversation
The execution-agnosticism tests only scanned {ctx.path}/use_cases/,
missing use case files nested under domain/use_cases/ or any other
subdirectory. Scan the entire bounded context path and match any .py
file containing 'use_cases' in its path instead.
absoludity
changed the title
absoludity
force-pushed
the
93-doctrine-scan-fix
branch
from
7bdee6c to
851ed99
Compare
absoludity
changed the title
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous PR #118 only scanned the business contexts' "use_cases" directory, whereas other BC's use BC/domain/use_cases.py. This change updates to check any use_cases directories within the BC.
Summary
TestExecutionAgnosticismtests which only scanned{ctx.path}/use_cases/, missing files indomain/use_cases/or other nested locations.pyfile withuse_casesin its path (still excludingtests/dirs)credential/domain/use_cases/initialize_system_data.py) rather than just the filenameTest plan
pytest src/julee/core/doctrine/— 15 passed against julee itself