entities: enforce immutability doctrine across domain models#120
Closed
absoludity wants to merge 0 commit into
Closed
entities: enforce immutability doctrine across domain models#120absoludity wants to merge 0 commit into
absoludity wants to merge 0 commit into
Conversation
d476e6a to
d554307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #94 . Follows #119 (ignore the branch name). Much of the diff is just fixing to use
model_copyor using tuples instead of lists etc.Domain models are records — snapshots of business state — not stateful objects. Without an explicit contract, mutable collections creep in (list, dict), direct field assignment happens in use cases and repositories, and the distinction between "changing an entity" and "creating a new snapshot" becomes unclear. This matters especially in Temporal workflows where shared in-memory state across signal handlers and activity calls is a source of subtle replay bugs.
A new
Entitybase class establishes the contract:frozen=Trueprevents field reassignment, and two new doctrine tests enforce that all domain models inherit fromEntityand use only immutable collection annotations (tuple,Mapping,frozenset).All ceap and polling domain models now extend
Entity. Mutablelist/dictannotations have been replaced withtuple/Mapping. The repository base classes (memory and minio) previously mutated entity fields directly inupdate_timestamps— these now return new instances viamodel_copy. Use cases that assigned to entity fields mid-workflow do the same.Test plan
pytest src/julee/core/doctrine/ --no-cov -v— 17 passed (2 new immutability tests)pytest src/ -m unit --no-cov -q— 504 passed