osdc: remove the now-unused -opt modules#904
Open
jeanschmidt wants to merge 2 commits into
Open
Conversation
This was referenced Jul 15, 2026
tofu plan — meta-prod-aws-ue2✅ Plan succeeded · commit Plan output |
tofu plan — meta-prod-aws-uw1✅ Plan succeeded · commit Plan output |
tofu plan — meta-prod-aws-ue1✅ Plan succeeded · commit Plan output |
tofu plan — lf-prod-aws-ue1✅ Plan succeeded · commit Plan output |
tofu plan — lf-prod-aws-ue2✅ Plan succeeded · commit Plan output |
huydhn
approved these changes
Jul 15, 2026
jeanschmidt
added a commit
that referenced
this pull request
Jul 16, 2026
**Impact:** repository cleanup only — no cluster references these modules, nothing redeploys **Risk:** low Delete `modules/arc-runners-opt` and `modules/nodepools-opt` in full. meta-prod-aws-ue1 was the only consumer and has been cut over to the regular `arc-runners`/`nodepools` modules, which now carry the same optimizations. With no cluster referencing them, these directories are dead code. - The generic `-opt` suffix handling in the shared scripts (shard grouping, module-gate normalization) is intentionally left in place — it operates on in-memory config, not these directories, and keeps working for any future `-opt` canary. `just lint`/`just test` pass, including the tests that exercise that suffix logic. ghstack-source-id: 10fc124 Pull-Request: #904
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Impact: repository cleanup only — no cluster references these modules, nothing redeploys
Risk: low
Delete
modules/arc-runners-optandmodules/nodepools-optin full.meta-prod-aws-ue1 was the only consumer and has been cut over to the regular
arc-runners/nodepoolsmodules, which now carry the same optimizations.With no cluster referencing them, these directories are dead code.
-optsuffix handling in the shared scripts (shard grouping,module-gate normalization) is intentionally left in place — it operates on
in-memory config, not these directories, and keeps working for any future
-optcanary.just lint/just testpass, including the tests thatexercise that suffix logic.