Skip to content

Add metadata column family fields to EmbeddingRocksDB (#5890) #5890

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lizhe-ji wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −0
Open

Add metadata column family fields to EmbeddingRocksDB (#5890) #5890

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
18005fd
Add metadata_dim_ and total_rows_written_ members to EmbeddingRocksDB…
Jun 15, 2026
581a46b
Add metadata column family fields to EmbeddingRocksDB (#5890)
Jun 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions fbgemm_gpu/src/ssd_split_embeddings_cache/ssd_table_batched_embeddings.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,8 @@
#pragma once

#include <algorithm>
#include <cstring>
#include <ctime>
#include <iostream>
#include <memory>

Expand Down Expand Up @@ -1376,11 +1378,13 @@ class EmbeddingRocksDB : public kv_db::EmbeddingKVDB {
friend class CheckpointHandle;

std::vector<std::unique_ptr<rocksdb::DB>> dbs_;
std::vector<rocksdb::ColumnFamilyHandle*> metadata_cf_handles_;
std::vector<std::unique_ptr<Initializer>> initializers_;
std::unique_ptr<folly::CPUThreadPoolExecutor> executor_;
rocksdb::ReadOptions ro_{};
rocksdb::WriteOptions wo_{};
std::shared_ptr<rocksdb::RateLimiter> rate_limiter_;
rocksdb::ColumnFamilyOptions cf_options_;
std::vector<int64_t> shard_flush_compaction_deadlines_;
bool done_staggered_flushes_;
int64_t memtable_flush_offset_;
Expand All @@ -1396,10 +1400,12 @@ class EmbeddingRocksDB : public kv_db::EmbeddingKVDB {
std::atomic<int64_t> fwd_l1_eviction_dur_{0};
std::atomic<int64_t> bwd_l1_cnflct_miss_write_back_dur_{0};
std::atomic<int64_t> flush_write_dur_{0};
std::atomic<int64_t> total_rows_written_{0}; // cumulative actual rows written

std::unordered_map<const SnapshotHandle*, std::unique_ptr<SnapshotHandle>>
snapshots_;
int64_t max_D_;
int64_t metadata_dim_;
int64_t elem_size_;
std::vector<int64_t> sub_table_dims_;
std::vector<int64_t> sub_table_hash_cumsum_;
Expand Down
Loading