Add metadata column family fields to EmbeddingRocksDB (#5890)#5890
Open
lizhe-ji wants to merge 2 commits into
Open
Add metadata column family fields to EmbeddingRocksDB (#5890)#5890lizhe-ji wants to merge 2 commits into
lizhe-ji wants to merge 2 commits into
Conversation
added 2 commits
June 15, 2026 11:03
…pytorch#5883) Summary: X-link: facebookresearch/FBGEMM#2802 Declare two new EmbeddingRocksDB member fields used by the metadata column family feature later in the stack: - metadata_dim_: width of the metaheader stored in the separate metadata CF - total_rows_written_: cumulative count of rows written Reviewed By: EddyLXJ Differential Revision: D108342270
Summary: Declare the metadata column family member fields (metadata_cf_handles_, cf_options_) and add the required includes. These are used by the metadata methods and existing-method wiring that follow in the stack. Differential Revision: D108357928
meta-codesync
Bot
changed the title
lizhe-ji
force-pushed
the
export-D108357928
branch
from
d9053a6 to
581a46b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Declare the metadata column family member fields (metadata_cf_handles_,
cf_options_) and add the required includes. These are used by the metadata
methods and existing-method wiring that follow in the stack.
Differential Revision: D108357928