Skip to content

Improve website accessibility to address Lighthouse audit findings from #7019 #7029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Shanwis wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Improve website accessibility to address Lighthouse audit findings from #7019 #7029

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion docs/assets/scss/_styles_project.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,16 @@

.long-description {
font-weight: 600;
color: $gray-500;
color: #c9d1e0;
margin-bottom: 2.5rem;
}

.btn-secondary {
color: #1a2744;
background: #28beeb;
border-color: #28beeb;
}

.core-values {
max-width: 80rem;
}
Expand Down Expand Up @@ -65,6 +71,19 @@
margin-left: -1rem;
}

footer a {
text-decoration: underline;
color: inherit;
}

.td-cover-block a {
text-decoration: underline;
}

.td-box a {
text-decoration: underline;
}


@include media-breakpoint-down(md) {
.value-title {
Expand Down
6 changes: 3 additions & 3 deletions docs/content/en/_index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,13 @@
</div>

<div class="mx-auto">
<a class="btn btn-lg btn-primary mr-3 mb-4" target="_blank" href="https://play.pipecd.dev?project=play">
<a class="btn btn-lg btn-primary mr-3 mb-4" target="_blank" rel="noopener noreferrer" href="https://play.pipecd.dev?project=play">
Try on Playground <i class="fas fa-arrow-alt-circle-right ml-2"></i>
</a>
<a class="btn btn-lg btn-primary mr-3 mb-4" href="https://pipecd.dev/docs/quickstart/">
Quick Start <i class="fas fa-arrow-alt-circle-right ml-2"></i>
</a>
<a class="btn btn-lg btn-secondary mr-3 mb-4" target="_blank" href="https://github.com/pipe-cd/pipecd">
<a class="btn btn-lg btn-secondary mr-3 mb-4" target="_blank" rel="noopener noreferrer" href="https://github.com/pipe-cd/pipecd">
GitHub <i class="fab fa-github ml-2 "></i>
</a>
<a class="btn btn-lg btn-primary mr-3 mb-4" href="https://pipecd.dev/docs-v1.0.x/">
Expand All @@ -31,7 +31,7 @@
</div>

<div class="mx-auto">
<a class="release-panel" target="_blank" href="https://github.com/pipe-cd/pipecd/releases">
<a class="release-panel" target="_blank" rel="noopener noreferrer" href="https://github.com/pipe-cd/pipecd/releases">
PipeCD <span class="bolder">{{< blocks/latest_version >}}</span> is now available! Check out the release notes <i class="fas fa-arrow-alt-circle-right ml-2"></i>
</a>
</div>
Expand Down
14 changes: 7 additions & 7 deletions docs/layouts/partials/footer.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,22 +5,22 @@
{{ if .IsHome }} {{ $text_color = "text-dark" }} {{ end }}
{{ $cncf_logo := "https://www.cncf.io/wp-content/uploads/2022/05/CNCF_logo_white.svg" }}
{{ if .IsHome }} {{ $cncf_logo = "https://www.cncf.io/wp-content/uploads/2022/07/cncf-color-bg.svg" }} {{ end }}
<div class="{{ $bg_color }} row d-print-none">
<footer class="{{ $bg_color }} row d-print-none">
<div class="container-fluid py-3 mx-sm-5">
<div class="row">
<div class="col-8 py-3 order-sm-2 {{ $text_color }}">
<a href="https://www.cncf.io/projects/pipecd/" target="_blank">
<img src="{{ $cncf_logo }}" alt="cncf logo" width="250">
<div class="py-2 {{ $text_color }}">PipeCD is a Cloud Native Computing Foundation sandbox project.</div>
<p class="py-2 {{ $text_color }}">PipeCD is a Cloud Native Computing Foundation sandbox project.</p>
</a>
</div>
<div class="col-4 order-sm-3 d-flex align-items-center justify-content-center">
{{ with $links }}
{{ with index . "developer"}}
<ul class="list-inline mb-0">
{{ range . }}
<li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title="{{ .name }}" aria-label="{{ .name }}">
<a class="text-white" target="_blank" rel="noopener noreferrer" href="{{ .url }}">
<li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title="{{ .name }}">
<a class="text-white" target="_blank" rel="noopener noreferrer" href="{{ .url }}" aria-label="{{ .name }}">
<i class="{{ .icon }} {{ $text_color }}"></i>
</a>
</li>
Expand All @@ -30,8 +30,8 @@
{{ with index . "user"}}
<ul class="list-inline mb-0">
{{ range . }}
<li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title="{{ .name }}" aria-label="{{ .name }}">
<a class="text-white" target="_blank" rel="noopener noreferrer" href="{{ .url }}">
<li class="list-inline-item mx-2 h3" data-toggle="tooltip" data-placement="top" title="{{ .name }}">
<a class="text-white" target="_blank" rel="noopener noreferrer" href="{{ .url }}" aria-label="{{ .name }}">
<i class="{{ .icon }} {{ $text_color }}"></i>
</a>
</li>
Expand All @@ -48,4 +48,4 @@
see <a href="https://www.linuxfoundation.org/trademark-usage/">Trademark Usage</a>.</small>
</div>
</div>
</div>
</footer>
2 changes: 1 addition & 1 deletion docs/layouts/partials/navbar-version-selector.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<a class="nav-link dropdown-toggle navbar-version-menu" href="#" id="navbarDropdown" role="button" data-toggle="dropdown" aria-haspopup="true" aria-expanded="false">
{{ (index .Site.Params.versions 1).version }}
</a>
<div class="dropdown-menu" aria-labelledby="navbarDropdownMenuLink">
<div class="dropdown-menu" aria-labelledby="navbarDropdown">
{{ range .Site.Params.versions }}
<a class="dropdown-item" href="{{ .url }}">{{ .version }}</a>
{{ end }}
Expand Down
4 changes: 2 additions & 2 deletions docs/layouts/partials/navbar.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{{ $cover := .HasShortcode "blocks/cover" }}
<nav class="js-navbar-scroll navbar navbar-expand navbar-dark {{ if $cover}} td-navbar-cover {{ end }}flex-column flex-md-row td-navbar">
<nav class="js-navbar-scroll navbar navbar-expand navbar-dark {{ if $cover}} td-navbar-cover {{ end }}flex-column flex-md-row td-navbar" aria-label="Main navigation">
{{ if not $cover }}
<a class="navbar-brand" href="{{ .Site.Home.RelPermalink }}">
<span class="navbar-logo">{{ if .Site.Params.ui.navbar_logo }}{{ with resources.Get "icons/logo.svg" }}{{ ( . | minify).Content | safeHTML }}{{ end }}{{ end }}</span>
Expand All @@ -16,7 +16,7 @@
{{ end }}
{{ $url := urls.Parse .URL }}
{{ $baseurl := urls.Parse $.Site.Params.Baseurl }}
<a class="nav-link{{if $active }} active{{end}}" href="{{ with .Page }}{{ .RelPermalink }}{{ else }}{{ .URL | relLangURL }}{{ end }}" {{ if ne $url.Host $baseurl.Host }}target="_blank" {{ end }}><span{{if $active }} class="active"{{end}}>{{ .Name }}</span></a>
<a class="nav-link{{if $active }} active{{end}}" href="{{ with .Page }}{{ .RelPermalink }}{{ else }}{{ .URL | relLangURL }}{{ end }}" {{ if ne $url.Host $baseurl.Host }}target="_blank" rel="noopener noreferrer"{{ end }}><span{{if $active }} class="active"{{end}}>{{ .Name }}</span></a>
</li>
{{ end }}
{{ if and .Site.Params.versions (not .IsHome) (ne .Section "community") (ne .Section "blog") }}
Expand Down
4 changes: 2 additions & 2 deletions docs/layouts/partials/sidebar-tree.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,14 +5,14 @@
{{ if not .Site.Params.ui.sidebar_search_disable -}}
<form class="td-sidebar__search d-flex align-items-center">
{{ partial "search-input.html" . }}
<button class="btn btn-link td-sidebar__toggle d-md-none p-0 ml-3 fas fa-bars" type="button" data-toggle="collapse" data-target="#td-section-nav" aria-controls="td-docs-nav" aria-expanded="false" aria-label="Toggle section navigation">
<button class="btn btn-link td-sidebar__toggle d-md-none p-0 ml-3 fas fa-bars" type="button" data-toggle="collapse" data-target="#td-section-nav" aria-controls="td-section-nav" aria-expanded="false" aria-label="Toggle section navigation">
</button>
</form>
{{ else -}}
<div id="content-mobile">
<form class="td-sidebar__search d-flex align-items-center">
{{ partial "search-input.html" . }}
<button class="btn btn-link td-sidebar__toggle d-md-none p-0 ml-3 fas fa-bars" type="button" data-toggle="collapse" data-target="#td-section-nav" aria-controls="td-docs-nav" aria-expanded="false" aria-label="Toggle section navigation">
<button class="btn btn-link td-sidebar__toggle d-md-none p-0 ml-3 fas fa-bars" type="button" data-toggle="collapse" data-target="#td-section-nav" aria-controls="td-section-nav" aria-expanded="false" aria-label="Toggle section navigation">
</button>
</form>
</div>
Expand Down
2 changes: 1 addition & 1 deletion docs/layouts/shortcodes/blocks/feature.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,5 @@
</div>
<p class="h4">{{ .Get "title" | markdownify }}</p>
<p class="mb-0">{{ .Inner }}</p>
{{ with .Get "url" }}<p><a href="{{ . }}">{{ with $url_text }}{{ $url_text }}{{ else }}{{ T "ui_read_more" }}{{ end }} …</a></p>{{ end }}
{{ with .Get "url" }}<p><a href="{{ . }}" aria-label="{{ with $url_text }}{{ $url_text }}{{ else }}{{ T "ui_read_more" }}{{ end }} - {{ $.Get "title" }}">{{ with $url_text }}{{ $url_text }}{{ else }}{{ T "ui_read_more" }}{{ end }} …</a></p>{{ end }}
</div>
6 changes: 4 additions & 2 deletions docs/layouts/shortcodes/blocks/value.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
{{ $_hugo_config := `{ "version": 1 }` }}
{{ $value_image := resources.GetMatch (printf "**%s*" .Params.image) }}
{{ $value_title := .Params.title }}

<div class="row justify-content-center core-value {{ if eq .Params.image_position "right" }} flex-row-reverse {{ end }} border-bottom">

Expand All @@ -14,6 +15,7 @@
class="mw-100 h-auto align-self-center"
width="500"
height="250"
alt="{{ $value_title }}"
src="{{ $image_resized_500.RelPermalink }}"
srcset="{{ $image_resized_500.RelPermalink }},
{{ $image_resized_750.RelPermalink }} 1.5x,
Expand All @@ -26,7 +28,7 @@
{{ end }}

<div class="col-md">
<div class="value-title h2">{{ .Params.title }}</div>
<p class="value-body">{{ .Inner }}</p>
<h2 class="value-title">{{ $value_title }}</h2>
<div class="value-body">{{ .Inner }}</div>
</div>
</div>
Loading