Improve website accessibility to address Lighthouse audit findings from #7019#7029
Improve website accessibility to address Lighthouse audit findings from #7019#7029Shanwis wants to merge 1 commit into
Conversation
|
👋 Hi @Shanwis, welcome to PipeCD and thanks for opening your first pull request! We’re really happy to have you here Before your PR gets merged, please check a few important things below. Helpful resources
DCO Sign-offAll commits must include a In case you forget to sign-off your commit(s), follow these steps: For the last commit: git commit --amend --signoff
git push --force-with-leaseFor multiple commits: git rebase --signoff origin/master
git push --force-with-leaseRun checks locallyBefore pushing updates, please run: make checkThis runs the same checks as CI and helps catch issues early. 💬 Need help?If anything is unclear, feel free to ask in this PR or join us on the CNCF Slack in the #pipecd channel. Thanks for contributing to PipeCD! ❤️ |
c220247 to
73bcb18
Compare
|
@Shanwis looks good to me |
pipe-cd#7019 Signed-off-by: Shanwis <ashsanthosh8@gmail.com>
73bcb18 to
173ce19
Compare
|
Hi @mohammedfirdouss @Warashi @khanhtc1202 @t-kikuc, please do review when you get the time |
What this PR does:
This PR addresses a focused subset of the Lighthouse accessibility recommendations from Issue #7019, improving the website's accessibility score from 81 to 100 without changing its appearance or functionality.
Direct Lighthouse Failure Fixes
General Improvements (not in Lighthouse failures)
<nav>element<div>→<footer>(semantic HTML)<div>→<p>(semantic HTML)<div class="value-title h2">→<h2 class="value-title">(proper heading hierarchy)<p class="value-body">→<div class="value-body">(fixes invalid<ul>inside<p>)Why we need it:
A Lighthouse audit identified several opportunities to improve the website's accessibility. This PR addresses the remaining automated accessibility failures (after #7020's SEO changes) by:
<h2>,<p>,<footer>,<nav>) for proper document structure and landmark navigationWhich issue(s) this PR fixes:
Fixes #7019
Does this PR introduce a user-facing change?:
Yes.