Skip to content

Refactors the contributor thank you workflow for quick fixes #6897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Warashi merged 3 commits into from
Jun 7, 2026
Merged

Refactors the contributor thank you workflow for quick fixes #6897

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db5ac64
Refactorst the contributor thank you workflow to fix a security issue…
Ayushmore1214 Jun 5, 2026
9753497
Update thank-you.yaml
Ayushmore1214 Jun 7, 2026
ca6724a
Merge branch 'master' into Ayushmore1214-patch-1
Ayushmore1214 Jun 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 2 additions & 9 deletions .github/workflows/thank-you.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,11 +11,9 @@ permissions:

jobs:
thank-you:
# Only run if the PR was actually merged
if: github.event.pull_request.merged
if: github.event.pull_request.merged == true
runs-on: ubuntu-latest
steps:
# We must check out the code to read the MAINTAINERS.json file
- name: Checkout repository
uses: actions/checkout@v4

Expand All @@ -26,29 +24,24 @@ jobs:
const fs = require('fs');
const creator = context.payload.pull_request.user.login;

// Skip bots to avoid comment loops
if (creator.endsWith('[bot]')) {
console.log('Skipping bot account.');
return;
}

// Read maintainers list from JSON file
const maintainersData = JSON.parse(fs.readFileSync('MAINTAINERS.json', 'utf8'));
const maintainers = maintainersData.maintainers.map(m => m.toLowerCase());

// Skip core maintainers to avoid spamming the team
if (maintainers.includes(creator.toLowerCase())) {
console.log(`Skipping maintainer account: ${creator}`);
return;
}

const message = 'Thank you for contributing to PipeCD! The changes in this pull request will be part of the upcoming release!';
const message = `Thank you for contributing to PipeCD, @${creator}! The changes in this pull request will be part of the upcoming release!`;

// Post the comment to the PR
await github.rest.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.payload.pull_request.number,
body: message
});

Loading