Refactors the contributor thank you workflow for quick fixes#6897
Conversation
… and improve contributor experience
added ref: ${{ github.event.pull_request.base.sha }} to ensures that the workflow securely checks out code only from our default branch
CX : updated mentioning contributor's GitHub username (@username) upon merge, making the acknowledgement feel personalized.
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6897 +/- ##
=======================================
Coverage 29.38% 29.38%
=======================================
Files 601 601
Lines 64278 64278
=======================================
Hits 18886 18886
Misses 43924 43924
Partials 1468 1468
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| with: | ||
| ref: ${{ github.event.pull_request.base.sha }} |
There was a problem hiding this comment.
Please remove this change.
pull_request_target event's default GITHUB_SHA is the default branch (master), and it's used as the actions/checkout's default. It's not recommended to check out other branches.
https://docs.github.com/en/actions/reference/workflows-and-actions/events-that-trigger-workflows#pull_request_target
There was a problem hiding this comment.
@Warashi thanks for the review, have made the changes!
Signed-off-by: Ayush More <ayushmore42595@gmail.com>
|
Thank you for contributing to PipeCD, @Ayushmore1214! The changes in this pull request will be part of the upcoming release! |
2 participants
What this PR does: added ref: ${{ github.event.pull_request.base.sha }} to ensures that the workflow securely checks out code only from our default branch
CX : updated mentioning contributor's GitHub username (@username) upon merge
Why we need it:
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: NO