Skip to content

Adjustments to multi-alt mixed sites in illumina#41

Merged
DarianHole merged 3 commits into
devfrom
fix/three_base_iupac
May 11, 2026
Merged

Adjustments to multi-alt mixed sites in illumina#41
DarianHole merged 3 commits into
devfrom
fix/three_base_iupac

Conversation

@DarianHole

Copy link
Copy Markdown
Member

Fixing sites in the report where there are 2 alt bases mixed. Previously it would just show one base in the alt column for the sample and now it shows both

Also fixed that the correct genotype was being applied to these samples

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

This PR is against the main branch ❌

  • Do not close this PR
  • Click Edit and change the base to dev
  • This CI test will remain failed until you push a new commit

Hi @DarianHole,

It looks like this pull-request is has been made against the phac-nml/measeq main branch.
The main branch on nf-core repositories should always contain code from the latest release.
Because of this, PRs to main are only allowed if they come from the phac-nml/measeq dev branch.

You do not need to close this PR, you can change the target branch to dev by clicking the "Edit" button at the top of this page.
Note that even after this, the test will continue to show as failing until you push a new commit.

Thanks again for your contribution!

@DarianHole
DarianHole changed the base branch from main to dev May 8, 2026 12:53
@github-actions

github-actions Bot commented May 8, 2026

Copy link
Copy Markdown

nf-core pipelines lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7e7e044

+| ✅ 177 tests passed       |+
#| ❔  52 tests were ignored |#
!| ❗   7 tests had warnings |!
Details

❗ Test warnings:

  • nextflow_config - Config manifest.version should end in dev: 1.2.0
  • pipeline_todos - TODO string in methods_description_template.yml: #Update the HTML below to your preferred methods description, e.g. add publication citation for this pipeline
  • pipeline_todos - TODO string in main.nf: Optionally add in-text citation tools to this list.
  • pipeline_todos - TODO string in main.nf: Optionally add bibliographic entries to this list.
  • pipeline_todos - TODO string in main.nf: Only uncomment below if logic in toolCitationText/toolBibliographyText has been filled!
  • pipeline_todos - TODO string in base.config: Check the defaults for all processes
  • pipeline_todos - TODO string in base.config: Customise requirements for specific processes.

❔ Tests ignored:

  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_exist - File is ignored: .github/CONTRIBUTING.md
  • files_exist - File is ignored: .github/.dockstore.yml
  • files_exist - File is ignored: conf/igenomes.config
  • files_exist - File is ignored: conf/igenomes_ignored.config
  • files_exist - File is ignored: conf/test.config
  • files_exist - File is ignored: conf/test_full.config
  • files_exist - File is ignored: assets/email_template.txt
  • files_exist - File is ignored: assets/email_template.html
  • files_exist - File is ignored: assets/sendmail_template.txt
  • files_exist - File is ignored: assets/adaptivecard.json
  • files_exist - File is ignored: assets/slackreport.json
  • files_exist - File is ignored: assets/nf-core-measeq_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-measeq_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-measeq_logo_dark.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: ro-crate-metadata.json
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • nextflow_config - Config variable ignored: process.cpus
  • nextflow_config - Config variable ignored: process.memory
  • nextflow_config - Config variable ignored: process.time
  • nextflow_config - Config variable ignored: validation.help.beforeText
  • nextflow_config - Config variable ignored: validation.help.afterText
  • nextflow_config - Config variable ignored: validation.summary.beforeText
  • nextflow_config - Config variable ignored: validation.summary.afterText
  • files_unchanged - File does not exist: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File does not exist: .github/.dockstore.yml
  • files_unchanged - File does not exist: .github/CONTRIBUTING.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/feature_request.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting_comment.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File does not exist: assets/email_template.html
  • files_unchanged - File does not exist: assets/email_template.txt
  • files_unchanged - File does not exist: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-measeq_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-measeq_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-measeq_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • files_unchanged - File ignored due to lint config: .gitignore or .prettierignore
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/measeq/measeq/.github/workflows/awstest.yml
  • multiqc_config - multiqc_config

✅ Tests passed:

Run details

  • nf-core/tools version 3.2.1
  • Run at 2026-05-11 16:02:55

@DarianHole

Copy link
Copy Markdown
Member Author

Ahmed looked it over, ready to merge

@DarianHole
DarianHole merged commit d54e867 into dev May 11, 2026
8 checks passed
@DarianHole
DarianHole deleted the fix/three_base_iupac branch May 11, 2026 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant