Repository navigation
fix(ingest): live filter rejects direct file links whose live_status is unset - #301
Open
WaveHost77 wants to merge 2 commits into
Open
WaveHost77 wants to merge 2 commits into
WaveHost77 wants to merge 2 commits into
Conversation
…is unset
The --match-filter backstop added to refuse live and upcoming streams uses
live_status!=is_upcoming. yt-dlp treats a comparison against a missing field
as a match failure, so every source whose extractor does not set live_status
(a direct .mp4 URL among them) is refused as a live stream:
This link is a live stream (or one that has not started yet)...
Confirmed against a plain S3-hosted mp4 with yt-dlp 2026.10.26:
!is_live passes, live_status!=is_upcoming silently rejects, and the lookup
above (peek) reports live=false for the same link.
Keep only !is_live in the filter: the peek lookup already refuses live and
upcoming streams through the info dict, where an unset live_status is read
correctly. The filter stays as the backstop for links the lookup could not
tell.
Signed-off-by: WaveHost77 <WaveHost77@users.noreply.github.com>
|
@WaveHost77 is attempting to deploy a commit to the Dillon Streator's projects Team on Vercel. A member of the Team first needs to authorize it. |
…tions honestly - NOT_LIVE_FILTER uses the none-inclusive `live_status!=?is_upcoming`, so a link whose extractor leaves live_status unset (a direct .mp4) passes while an upcoming stream the lookup could not check is still skipped. - A download the filter skips is reported as a live stream only when the lookup could not tell; when the lookup said not live, ingest logs an error and fails with cause platform instead of blaming the link. - Test that every comparison in the filter is none-inclusive; changeset; TROUBLESHOOTING note. Signed-off-by: dillonstreator <dillonstreator@gmail.com>
Member
|
Thanks for the clear report and repro, @WaveHost77! I pushed a commit on top of yours:
One thing left on your side: the CLA check. Please read CLA.md, then add a line with your GitHub login to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #300
Summary
--match-filteradded in #296 useslive_status!=is_upcoming. yt-dlp treats a comparison against a missing field as a match failure, so every source whose extractor does not setlive_status(direct.mp4URLs among them) is refused as a live stream on every attempt. Thepeeklookup already refuses live and upcoming streams from the info dict, where an unsetlive_statusreads correctly, so the filter can keep only!is_liveas the backstop.Evidence (yt-dlp 2026.10.26, plain S3-hosted mp4)
!is_live→ passeslive_status!=is_upcoming→ silently rejects (exit 0, no output)live=falsefor the same linkTest
A 2.8 GB
https://…/111.mp4link failed 4/4 ingest attempts before; with the change it ingests normally.Signed-off per CONTRIBUTING.md (
git commit -s).