Skip to content

fix(ingest): live filter rejects direct file links whose live_status is unset - #301

Open
WaveHost77 wants to merge 2 commits into
osbytes:mainfrom
WaveHost77:fix/live-filter-rejects-direct-files
Open

WaveHost77 wants to merge 2 commits into
osbytes:mainfrom
WaveHost77:fix/live-filter-rejects-direct-files

Conversation

@WaveHost77

Copy link
Copy Markdown

Fixes #300

Summary

--match-filter added in #296 uses live_status!=is_upcoming. yt-dlp treats a comparison against a missing field as a match failure, so every source whose extractor does not set live_status (direct .mp4 URLs among them) is refused as a live stream on every attempt. The peek lookup already refuses live and upcoming streams from the info dict, where an unset live_status reads correctly, so the filter can keep only !is_live as the backstop.

Evidence (yt-dlp 2026.10.26, plain S3-hosted mp4)

  • !is_live → passes
  • live_status!=is_upcoming → silently rejects (exit 0, no output)
  • lookup reports live=false for the same link

Test

A 2.8 GB https://…/111.mp4 link failed 4/4 ingest attempts before; with the change it ingests normally.

Signed-off per CONTRIBUTING.md (git commit -s).

…is unset

The --match-filter backstop added to refuse live and upcoming streams uses
live_status!=is_upcoming. yt-dlp treats a comparison against a missing field
as a match failure, so every source whose extractor does not set live_status
(a direct .mp4 URL among them) is refused as a live stream:

    This link is a live stream (or one that has not started yet)...

Confirmed against a plain S3-hosted mp4 with yt-dlp 2026.10.26:
!is_live passes, live_status!=is_upcoming silently rejects, and the lookup
above (peek) reports live=false for the same link.

Keep only !is_live in the filter: the peek lookup already refuses live and
upcoming streams through the info dict, where an unset live_status is read
correctly. The filter stays as the backstop for links the lookup could not
tell.

Signed-off-by: WaveHost77 <WaveHost77@users.noreply.github.com>
@vercel

vercel Bot commented Nov 19, 2026

Copy link
Copy Markdown

@WaveHost77 is attempting to deploy a commit to the Dillon Streator's projects Team on Vercel.

A member of the Team first needs to authorize it.

…tions honestly

- NOT_LIVE_FILTER uses the none-inclusive `live_status!=?is_upcoming`, so a link
  whose extractor leaves live_status unset (a direct .mp4) passes while an
  upcoming stream the lookup could not check is still skipped.
- A download the filter skips is reported as a live stream only when the
  lookup could not tell; when the lookup said not live, ingest logs an error
  and fails with cause platform instead of blaming the link.
- Test that every comparison in the filter is none-inclusive; changeset;
  TROUBLESHOOTING note.

Signed-off-by: dillonstreator <dillonstreator@gmail.com>
@dillonstreator

Copy link
Copy Markdown
Member

Thanks for the clear report and repro, @WaveHost77! I pushed a commit on top of yours:

  • The filter keeps the upcoming-stream backstop, but none-inclusive: !is_live & live_status!=?is_upcoming. A direct .mp4 with no live_status passes, and an upcoming stream whose lookup failed is still skipped.
  • If the filter skips a link the lookup already called "not live", ingest no longer tells the user it's a live stream. It fails with a platform cause and logs an error, so a bug like this shows up as ours, not theirs.
  • A test that every comparison in the filter ends in ?, plus a changeset and a troubleshooting note.

One thing left on your side: the CLA check. Please read CLA.md, then add a line with your GitHub login to .github/cla-signatures.json in this PR (a signed-off commit, git commit -s, like your first one). That commit is your signature. After that we can merge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Direct file links (plain mp4 URL) are refused as a live stream by the live-stream match filter

2 participants