NETOBSERV-2748: YAML lint bug fix#80672
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@Amoghrd: This pull request references NETOBSERV-2748 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.0.0" version, but no target version was set. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe PR extends test execution timeouts in the NetObserv operator CI pipeline from 50–60 minutes to 8 hours and improves the YAML lint tooling by prepending ChangesTest Infrastructure Updates
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 14 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (14 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
/assign @memodi |
|
/pj-rehearse pull-ci-netobserv-netobserv-operator-main-e2etests-lint-fmt |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-netobserv-netobserv-operator-main-e2etests-lint-fmt |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-netobserv-netobserv-operator-main-e2etests-lint-fmt |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Amoghrd in this PR could you please update GINKGO_TIMEOUT to be 8 hours , I mistook it for case timeout, but it's actually a SUITE timeout, we should update the var name and description for it. That's the reason why you see the e2etest is failing on PR. We should also update the pod timeout to be 6-8 hours https://github.com/openshift/release/blob/main/ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yaml#L215 |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@ci-operator/step-registry/netobserv/ginkgo-tests/netobserv-ginkgo-tests-ref.yaml`:
- Around line 21-23: The documentation for the GINKGO_TIMEOUT parameter needs to
be more explicit about its scope. Update the documentation field value from the
current generic "Timeout for ginkgo test execution." to clearly specify that
this is a suite-level timeout (meaning the entire test suite must complete
within this duration, not individual test cases). This will prevent
misinterpretation of how the timeout applies when the parameter is consumed.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited)
Review profile: CHILL
Plan: Enterprise
Run ID: 3dcefce2-e166-4cfc-913c-058a49acafe8
⛔ Files ignored due to path filters (1)
ci-operator/jobs/netobserv/netobserv-operator/netobserv-netobserv-operator-main-presubmits.yamlis excluded by!ci-operator/jobs/**
📒 Files selected for processing (2)
ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yamlci-operator/step-registry/netobserv/ginkgo-tests/netobserv-ginkgo-tests-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (1)
- ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yaml
|
/pj-rehearse pull-ci-netobserv-netobserv-operator-main-e2etests-lint-fmt |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@Amoghrd, |
|
/pj-rehearse pull-ci-netobserv-netobserv-operator-main-e2etests-lint-fmt |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
YAML lint ran in job |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@jotak @OlivierCazade Could you approve as well? TIA! |
|
/pj-rehearse ack |
|
@Amoghrd: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
openshift-merge-bot
Bot
added
the
rehearsals-ack
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Amoghrd, jotak, memodi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
@Amoghrd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
4 participants
Summary by CodeRabbit
This PR updates NetObserv operator CI configuration to fix a YAML lint/formatting issue and to increase suite-level timeouts for Ginkgo-based e2e runs, improving reliability and preventing CI failures/timeouts.
Fix YAML lint/format job setup for
e2etests-lint-fmt(ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yaml)yamlfmtbinary can be found at runtime by prepending$GOPATH/bintoPATHbefore installation and execution.yamlfmt -lintacrosstestdata/**/*.yamland*.yml, preserving fail-fast behavior (ERROR: YAML lint failed for <file>) and emitting a finalyamllint SUCCESSmessage.Increase e2e job/pod timeout budget (
ci-operator/config/netobserv/netobserv-operator/netobserv-netobserv-operator-main.yaml)timeout: 8h0m0sfor thee2etestjob to align with suite-level execution needs.Align Ginkgo suite timeout configuration (
ci-operator/step-registry/netobserv/ginkgo-tests/netobserv-ginkgo-tests-ref.yaml)netobserv-ginkgo-testsstep timeout from60mto8h.GINKGO_TIMEOUTdefault from50mto8hand revises its documentation to clarify it controls suite execution timeout (not per-test-case timeouts).Impact: NetObserv operator main-branch CI checks for YAML linting and subsequent e2e Ginkgo runs should be more stable due to correct lint tool discovery and more appropriate suite-level timeout settings.