Limit recert hardware jobs to intranet#80482
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: ⛔ Files ignored due to path filters (9)
📒 Files selected for processing (9)
✅ Files skipped from review due to trivial changes (2)
🚧 Files skipped from review as they are similar to previous changes (3)
WalkthroughAdds a ChangesIntranet Capability for Recert Tests
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: omertuc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
|
/pj-rehearse pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename |
|
@omertuc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
/pj-rehearse pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename |
|
@omertuc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
Otherwise ofcir times out on acquire when on the wrong cluster
|
/pj-rehearse pull-ci-rh-ecosystem-edge-recert-main-baremetalds-sno-recert-cluster-rename |
|
@omertuc: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
[REHEARSALNOTIFIER]
Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
@omertuc: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
1 participant
Otherwise ofcir times out on acquire when on the wrong cluster
Summary by CodeRabbit
This PR updates the rh-ecosystem-edge recert CI operator configs to restrict the baremetalds-sno-recert-cluster-rename test to run only on intranet-capable clusters. Concretely, it adds a capabilities: [intranet] entry to the baremetalds-sno-recert-cluster-rename test in the following CI config files:
Practical effect: these hardware-dependent recert jobs will only be scheduled on clusters labeled for intranet access, preventing failures (e.g., ofcir acquire timeouts) when they would otherwise run on clusters lacking the required internal connectivity.
Note: I verified the changes in the repository; the jobs still use the existing cluster_profile (equinix-edge-enablement) in the shown hunks — the PR only adds the intranet capability flag.