Skip to content

Enable logger usage checks in security subprojects #6210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cwperks merged 4 commits into from
Jun 16, 2026
Merged

Enable logger usage checks in security subprojects #6210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1673455
Enable logger usage checks in security subprojects
cwperks Jun 13, 2026
7941c18
Pin Gradle GitHub Actions references
cwperks Jun 13, 2026
52a7118
Update opensearch-build workflow pins
cwperks Jun 14, 2026
525397b
Merge branch 'main' into enable-logger-usage-check
cwperks Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,9 +392,6 @@ opensearchplugin {
extendedPlugins = ['rule-framework', 'workload-management;optional=true', 'transport-grpc;optional=true']
}

// This requires an additional Jar not published as part of build-tools
loggerUsageCheck.enabled = false

publishing {
publications {
pluginZip(MavenPublication) { publication ->
Expand Down
1 change: 0 additions & 1 deletion bwc-test/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ dependencies {

}

loggerUsageCheck.enabled = false
testingConventions.enabled = false
validateNebulaPom.enabled = false

Expand Down
1 change: 0 additions & 1 deletion sample-resource-plugin/build.gradle
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ opensearchplugin {

dependencyLicenses.enabled = false
thirdPartyAudit.enabled = false
loggerUsageCheck.enabled = false
validateNebulaPom.enabled = false
testingConventions.enabled = false
tasks.configureEach { task ->
Expand Down
3 changes: 2 additions & 1 deletion .../java/org/opensearch/sample/resource/actions/transport/UpdateResourceTransportAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.message.ParameterizedMessage;

import org.opensearch.action.index.IndexRequest;
import org.opensearch.action.support.ActionFilters;
Expand Down Expand Up @@ -78,7 +79,7 @@ private void updateResource(UpdateResourceRequest request, ActionListener<Create
}, listener::onFailure));
}
} catch (Exception e) {
log.error("Failed to update resource: {}", request.getResourceId(), e);
log.error(() -> new ParameterizedMessage("Failed to update resource: {}", request.getResourceId()), e);
listener.onFailure(e);
}

Expand Down
3 changes: 2 additions & 1 deletion ...opensearch/sample/resourcegroup/actions/transport/UpdateResourceGroupTransportAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@

import org.apache.logging.log4j.LogManager;
import org.apache.logging.log4j.Logger;
import org.apache.logging.log4j.message.ParameterizedMessage;

import org.opensearch.action.index.IndexRequest;
import org.opensearch.action.support.ActionFilters;
Expand Down Expand Up @@ -78,7 +79,7 @@ private void updateResource(UpdateResourceGroupRequest request, ActionListener<C
}, listener::onFailure));
}
} catch (Exception e) {
log.error("Failed to update resource: {}", request.getResourceId(), e);
log.error(() -> new ParameterizedMessage("Failed to update resource: {}", request.getResourceId()), e);
listener.onFailure(e);
}

Expand Down
Loading