Enable logger usage checks in security subprojects#6210
Merged
cwperks merged 4 commits intoJun 16, 2026
Conversation
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Signed-off-by: Craig Perkins <craig5008@gmail.com>
reta
approved these changes
Jun 14, 2026
Signed-off-by: Craig Perkins <craig5008@gmail.com>
Contributor
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
Contributor
PR Code Suggestions ✨Explore these optional code suggestions:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enables the logger usage precommit check for the Security repo subprojects where it can pass today:
sample-resource-pluginbwc-testThe sample resource plugin had two existing logger callsites that passed a throwable alongside parameterized arguments. Those now use
ParameterizedMessage, which matches the pattern accepted by OpenSearch's logger usage checker.The duplicate root-level disable/comment was also removed because the logger usage checker is now published through OpenSearch build-tools. The root project still keeps its existing disable near the other root precommit toggles because enabling it currently surfaces a larger backlog of existing logger usage violations in main/test code.
This also updates Security's GitHub Actions Gradle steps from the old pinned
gradle/gradle-build-actionreference togradle/actions/setup-gradlepinned to the full v3.5.0 commit SHA. The repository now rejects nested tag-based action references, and the old Gradle action delegates throughgradle/actions/setup-gradle@v3.5.0, which causes jobs to fail before checkout/build starts.Local composite BWC actions are also pinned so those jobs do not hit the same organization policy when they run.
The reusable
opensearch-buildworkflow references were also advanced to a newer full commit SHA. The older pinnedopensearch-buildcommit still used tag-based nested actions inget-ci-image-tagand the code diff workflows, which causedGet-CI-Image-TagandCode-Diff-Analyzerto fail before their jobs could run.Testing
./gradlew loggerUsageCheck opensearch-sample-resource-plugin:loggerUsageCheck opensearch-security-bwc-test:loggerUsageCheck./gradlew spotlessApply./gradlew precommitcurrently reaches the sample resource plugin and then fails on existingforbiddenApisMainviolations forURL#openStream()in the sample plugin. That is unrelated to this logger usage change.