Repository navigation
fix: hide internal error details in responses and await socket check in translation API - #4596
Merged
SteRiccio merged 1 commit intoOct 29, 2026
Conversation
…in translation API - sendErr returned unexpected errors as 'Could not serve: <error>', exposing table, column and constraint names; they are now logged and the client gets a generic message - translationApi negated the Promise returned by the now async WebSocketServer.isSocketConnected, so the missing-socket check never fired
|
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
SteRiccio
deleted the
fix/hide-internal-error-details-and-await-socket-check
branch
October 29, 2026 21:22
SteRiccio
added a commit
that referenced
this pull request
Oct 30, 2026
* fix: send error details to the client again in sendErr Unexpected error details help find the related log entry when a user reports an error. The server-side log line added in #4596 is kept. * fix: avoid throwing in sendErr when the error is null --------- Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Problem
Response.sendErrreturned any unexpected error asCould not serve: ${err.toString()}. For Postgres errors that exposes table, column and constraint names to the client.translationApichecked!WebSocketServer.isSocketConnected(socketId)withoutawait.isSocketConnectedbecame async with the multi-dyno WebSocket work, so the negated Promise was alwaysfalseand the "socket missing" check never fired: translations ran even when no socket could receive the result.Fix
appErrors:genericwithtext: 'Internal server error'.SystemError, arena-core'sSystemErrorandUnauthorizedErrorresponses are unchanged.await.The same error-detail fix for the error middleware in arena-server is in openforis/arena-server#225.
Tests
ESLint and Prettier pass on the changed files. I did not run the unit, integration or e2e suites locally.