Repository navigation
fix: send error details to the client again in sendErr - #4597
Merged
Merged
Conversation
Unexpected error details help find the related log entry when a user reports an error. The server-side log line added in #4596 is kept.
Contributor
|
This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again. |
|
2 of 8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



What
Partially reverts #4596:
Response.sendErrsends unexpected errors to the client again asappErrors:genericwithtext: 'Could not serve: <error>'. When a user reports an error, the details help find the related log entry without searching through the log files.Kept from #4596
logger.error(with the stack) for unexpected errors.awaitonWebSocketServer.isSocketConnectedin the translation API.