Skip to content

fix: send error details to the client again in sendErr - #4597

Merged
SteRiccio merged 4 commits into
masterfrom
fix/restore-error-details-in-responses
Oct 30, 2026
Merged

SteRiccio merged 4 commits into
masterfrom
fix/restore-error-details-in-responses

Conversation

@SteRiccio

Copy link
Copy Markdown
Member

What

Partially reverts #4596: Response.sendErr sends unexpected errors to the client again as appErrors:generic with text: 'Could not serve: <error>'. When a user reports an error, the details help find the related log entry without searching through the log files.

Kept from #4596

  • The server-side logger.error (with the stack) for unexpected errors.
  • The missing await on WebSocketServer.isSocketConnected in the translation API.

SteRiccio and others added 2 commits October 29, 2026 22:29
Unexpected error details help find the related log entry when a user reports
an error. The server-side log line added in #4596 is kept.
@SteRiccio SteRiccio self-assigned this Oct 30, 2026
@mergify

mergify Bot commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

This pull request does not currently match the merge queue conditions, so it cannot be queued from here. The box comes back if it matches again.

@sonarqubecloud

Copy link
Copy Markdown

@SteRiccio
SteRiccio merged commit b573314 into master Oct 30, 2026
12 checks passed
@SteRiccio
SteRiccio deleted the fix/restore-error-details-in-responses branch October 30, 2026 15:25
@SteRiccio SteRiccio mentioned this pull request Oct 30, 2026
2 of 8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant