Skip to content

feat: Add "Move Up" / "Move Down" menu items to lib unit components (backport)#3116

Merged
ChrisChV merged 1 commit into
openedx:release/verawoodfrom
open-craft:braden/backport-pr-3111-moveupdown
Jun 27, 2026
Merged

feat: Add "Move Up" / "Move Down" menu items to lib unit components (backport)#3116
ChrisChV merged 1 commit into
openedx:release/verawoodfrom
open-craft:braden/backport-pr-3111-moveupdown

Conversation

@bradenmacdonald

@bradenmacdonald bradenmacdonald commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

This is a backport of #3111

This is a workaround for #1994 "Cannot drag a component past a really long component on a unit page" (Since "autoscroll" is disabled in our usage of dnd-kit due to conflicts with our custom collision detection algorithm.)

This implements the workaround proposed in #3110.

I also re-organized the menu to put the destructive remove/delete menu options last, below a divider, for better consistency with course authoring.

Private ref: MNG-4985

…penedx#3111)

This is a workaround for openedx#1994 "Cannot drag a component past a really long component on a unit page" (Since "autoscroll" is disabled in our usage of dnd-kit due to conflicts with our custom collision detection algorithm.)

This implements the workaround proposed in openedx#3110.

I also re-organized the menu to put the destructive remove/delete menu options last, below a divider, for better consistency with course authoring.
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 26, 2026
@github-project-automation github-project-automation Bot moved this to Needs Triage in Contributions Jun 26, 2026
@codecov

codecov Bot commented Jun 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (release/verawood@255d8c8). Learn more about missing BASE report.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             release/verawood    #3116   +/-   ##
===================================================
  Coverage                    ?   95.52%           
===================================================
  Files                       ?     1392           
  Lines                       ?    32935           
  Branches                    ?     7347           
===================================================
  Hits                        ?    31461           
  Misses                      ?     1419           
  Partials                    ?       55           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ChrisChV ChrisChV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

  • I tested this: I followed the testing instructions in a Verawood instance
  • I read through the code and considered the security, stability and performance implications of the changes.
  • I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
  • Includes tests for bugfixes and/or features added.

@ChrisChV ChrisChV merged commit a787439 into openedx:release/verawood Jun 27, 2026
9 checks passed
@github-project-automation github-project-automation Bot moved this from Needs Triage to Done in Contributions Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants