feat: Add "Move Up" / "Move Down" menu items to lib unit components (backport)#3116
Conversation
…penedx#3111) This is a workaround for openedx#1994 "Cannot drag a component past a really long component on a unit page" (Since "autoscroll" is disabled in our usage of dnd-kit due to conflicts with our custom collision detection algorithm.) This implements the workaround proposed in openedx#3110. I also re-organized the menu to put the destructive remove/delete menu options last, below a divider, for better consistency with course authoring.
|
Thanks for the pull request, @bradenmacdonald! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/verawood #3116 +/- ##
===================================================
Coverage ? 95.52%
===================================================
Files ? 1392
Lines ? 32935
Branches ? 7347
===================================================
Hits ? 31461
Misses ? 1419
Partials ? 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
ChrisChV
left a comment
There was a problem hiding this comment.
Looks good 👍
- I tested this: I followed the testing instructions in a Verawood instance
- I read through the code and considered the security, stability and performance implications of the changes.
- I tested that the UI can be used with a keyboard only (tab order, keyboard controls).
- Includes tests for bugfixes and/or features added.
This is a backport of #3111
Private ref: MNG-4985