Skip to content

feat: Add "Move Up" / "Move Down" menu items to lib unit components#3111

Merged
ChrisChV merged 4 commits into
openedx:masterfrom
open-craft:braden/move-up-down
Jun 26, 2026
Merged

feat: Add "Move Up" / "Move Down" menu items to lib unit components#3111
ChrisChV merged 4 commits into
openedx:masterfrom
open-craft:braden/move-up-down

Conversation

@bradenmacdonald

@bradenmacdonald bradenmacdonald commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

This is a workaround for #1994 "Cannot drag a component past a really long component on a unit page" (Since "autoscroll" is disabled in our usage of dnd-kit due to conflicts with our custom collision detection algorithm.)

This implements the workaround proposed in #3110.

I also re-organized the menu to put the destructive remove/delete menu options last, below a divider, for better consistency with course authoring.

Description

Before After
Screenshot 2026-06-23 at 3 55 21 PM After

Testing instructions

Try using both regular drag-and-drop and the new menu items to re-order components in a library unit.

Private ref: MNG-4985

This is a workaround for openedx#1994 "Cannot drag a component past a really long component on a unit page"

Since "autoscroll" is disabled in our usage of dnd-kit due to conflicts with our custom collision detection algorithm.
@openedx-webhooks openedx-webhooks added open-source-contribution PR author is not from Axim or 2U core contributor PR author is a Core Contributor (who may or may not have write access to this repo). labels Jun 23, 2026
@openedx-webhooks

Copy link
Copy Markdown

Thanks for the pull request, @bradenmacdonald!

This repository is currently maintained by @bradenmacdonald.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

  • If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
    • This process (including the steps you'll need to take) is documented here.
  • If it doesn't, simply proceed with the next step.
🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

  • Dependencies

    This PR must be merged before / after / at the same time as ...

  • Blockers

    This PR is waiting for OEP-1234 to be accepted.

  • Timeline information

    This PR must be merged by XX date because ...

  • Partner information

    This is for a course on edx.org.

  • Supporting documentation
  • Relevant Open edX discussion forum threads
🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details
Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

  • The size and impact of the changes that it introduces
  • The need for product review
  • Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

@kdmccormick and/or @navinkarkera could you please review?

@codecov

codecov Bot commented Jun 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.63%. Comparing base (7e7eb0f) to head (3e2c904).
⚠️ Report is 6 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3111      +/-   ##
==========================================
+ Coverage   95.59%   95.63%   +0.03%     
==========================================
  Files        1403     1402       -1     
  Lines       33239    33222      -17     
  Branches     7780     7782       +2     
==========================================
- Hits        31775    31772       -3     
+ Misses       1415     1403      -12     
+ Partials       49       47       -2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-Authored-By: Claude <noreply@anthropic.com>
@navinkarkera navinkarkera self-requested a review June 24, 2026 06:24

@navinkarkera navinkarkera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald Looks good, just found one bug where if you use sidebar menu directly after using the move option once, it uses the old index and breaks the order.

Also, should we use optimistic updates to make the movement instant?

Comment thread src/library-authoring/components/ComponentMenu.tsx Outdated
Comment thread src/library-authoring/components/ComponentMenu.tsx
Comment thread src/library-authoring/components/ComponentMenu.tsx Outdated
@mphilbrick211 mphilbrick211 moved this from Needs Triage to In Eng Review in Contributions Jun 24, 2026
Co-authored-by: Navin Karkera <navin@disroot.org>
@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

Good catch - thanks @navinkarkera. I included those changes.

Also, should we use optimistic updates to make the movement instant?

That would be better, but it seems already pretty fast and this is an "emergency workaround" type situation, so I just want to merge the simplest version for now.

@navinkarkera navinkarkera left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bradenmacdonald Looks good. Feel free to merge this.

@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

Thanks @navinkarkera. @ChrisChV could you please review/approve this so I can merge?

@ChrisChV ChrisChV left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good! Thanks! 👍

@ChrisChV ChrisChV merged commit 8d5842b into openedx:master Jun 26, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from In Eng Review to Done in Contributions Jun 26, 2026
@bradenmacdonald bradenmacdonald deleted the braden/move-up-down branch June 26, 2026 17:34
@bradenmacdonald

Copy link
Copy Markdown
Contributor Author

Thanks @ChrisChV! Could you please approve the backport as well? #3116

ChrisChV pushed a commit that referenced this pull request Jun 27, 2026
…3111) (#3116)

This is a workaround for #1994 "Cannot drag a component past a really long component on a unit page" (Since "autoscroll" is disabled in our usage of dnd-kit due to conflicts with our custom collision detection algorithm.)

This implements the workaround proposed in #3110.

I also re-organized the menu to put the destructive remove/delete menu options last, below a divider, for better consistency with course authoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core contributor PR author is a Core Contributor (who may or may not have write access to this repo). open-source-contribution PR author is not from Axim or 2U

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

5 participants