Remove Jackson dependency from exporters#8546
Draft
brunobat wants to merge 1 commit into
Draft
Conversation
Assisted-By: Claude Opus 4.6 <noreply@anthropic.com>
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8546 +/- ##
============================================
+ Coverage 90.94% 90.95% +0.01%
- Complexity 10210 10284 +74
============================================
Files 1013 1016 +3
Lines 27175 27411 +236
Branches 3184 3203 +19
============================================
+ Hits 24714 24932 +218
- Misses 1734 1746 +12
- Partials 727 733 +6 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Partially fixes #8533
This was implemented as a PoC to evaluate the complexity of removing Jackson and do in house JSON serialization/deserialization to avoid the complexity of: #8544
It turns out that this has a lot more added code, but it's related with tests.
Serious review needs to be placed into
StreamingJsonWriterandStringJsonWriter.This shouldn't be the last location of the JSON classes. They need to be placed on a SDK common lib to allow consumption by Declarative Config.
Assisted-By: Claude Opus 4.6 noreply@anthropic.com