Replace jackson OTLP json serialization with handrolled version#8545
Open
jack-berg wants to merge 1 commit into
Open
Replace jackson OTLP json serialization with handrolled version#8545jack-berg wants to merge 1 commit into
jack-berg wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #8545 +/- ##
============================================
+ Coverage 90.97% 91.00% +0.03%
- Complexity 10206 10250 +44
============================================
Files 1013 1013
Lines 27166 27314 +148
Branches 3182 3200 +18
============================================
+ Hits 24713 24857 +144
- Misses 1729 1730 +1
- Partials 724 727 +3 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Contributor
|
Well... I think we have been working on the same :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #8533.
Jackson 3 was released and requires java 17.
We rely on jackson in a variety of places. This PR concerns the serialization functionality we rely on for
opentelemetry-exporter-logging-otlp,opentelemetry-exporter-otlp(officially json is not supproted - see #5833).Rather than try to accommodate different versions of jackson through something like SPI, its simpler to just replace jackson with a hand rolled version, at least for the JSON serialization bits.
We have precedent for hand rolled JSON serialization in JsonEncoding, which is used by Value. However, this operates in very different context than OTLP marshaling and probably shouldn't be merged together.