Repository navigation
Conversation
aviralni
force-pushed
the
pyzes_infolog
branch
from
September 23, 2026 06:03
796e835 to
fbd1a41
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Test failures are not propagated, warning results are mishandled, and the documented package version is inconsistent.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 3
Open (4)
What changed in this PR
Adds Python Sysman bindings and validation coverage for Info Log APIs.
Changes:
- Adds Info Log handles, enums, structures, and API wrappers.
- Adds unit and black-box tests.
- Documents supported Info Log APIs.
| File | Description |
|---|---|
pyzes.py |
Adds Info Log bindings. |
test_info_log.py |
Adds wrapper unit tests. |
pyzes_black_box_test.py |
Adds Info Log runtime tests and CLI option. |
README.md |
Documents API support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aviralni
force-pushed
the
pyzes_infolog
branch
from
September 28, 2026 09:06
fbd1a41 to
1e8fbd9
Compare
Add python bindings, unit tests, black box test coverage and README entries for: 1. zesDriverEnumInfoLogsExt 2. zesInfoLogGetPropertiesExt 3. zesInfoLogCreateInstanceExt 4. zesInfoLogInstanceReadWithMetadataExt 5. zesInfoLogInstancePeekWithMetadataExt 6. zesInfoLogInstanceDeleteExt Related-To: SYSM-432 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
Report info log properties by default and collect records only with --instance-api, --instance-peek or --instance-read as root.
A failed zesDriverEnumInfoLogsExt call printed an error but both -a and -l still exited with status 0. Aggregate the info log test result into the exit status. Info logs are driver scoped, so also run them when device enumeration fails or returns no devices. Related-To: SYSM-432 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
…ck box test ZE_RESULT_WARNING_DROPPED_DATA can be returned by a query call and still comes with a valid size and record count. The query helper passed no read status and its callers failed on the warning. Pass a read status, report the dropped record count and treat the warning as success, as queryInfoLogRecords in zello_sysman does. Related-To: SYSM-432 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
aviralni
force-pushed
the
pyzes_infolog
branch
from
October 8, 2026 07:17
6198259 to
8ee6177
Compare
…box test zello_sysman runs the info log test with -L and takes --instanceapi, --instancepeek, --instanceread and --buffersize. Use the same spellings instead of -l, --instance-api, --instance-peek, --instance-read and --buffer-size. Related-To: SYSM-432 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
Add python bindings, unit tests, black box test coverage and README entries for: 1. zesDriverEnumInfoLogsExt 2. zesInfoLogGetPropertiesExt 3. zesInfoLogCreateInstanceExt 4. zesInfoLogInstanceReadWithMetadataExt 5. zesInfoLogInstancePeekWithMetadataExt 6. zesInfoLogInstanceDeleteExt Related-To: SYSM-432 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
joshuaranjan
approved these changes
Oct 9, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feature: Add pyzes support for info log APIs
Add python bindings, unit tests, black box test coverage and README
entries for:
Related-To: SYSM-432
Signed-off-by: Aviral Nigam aviral.nigam@intel.com