Repository navigation
Conversation
aviralni
force-pushed
the
pyzes_driver
branch
from
September 23, 2026 06:03
fbcc801 to
a6d2987
Compare
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Driver-scoped black-box tests must run independently of device enumeration.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
What changed in this PR
Adds Python bindings, tests, examples, and documentation for six Sysman driver APIs.
Changes:
- Adds driver structures, event flags, and API wrappers.
- Adds unit and black-box test coverage.
- Documents supported driver APIs.
| File | Review |
|---|---|
bindings/sysman/python/test/unit_tests/test_driver.py |
Adds unit tests for the new wrappers. |
bindings/sysman/python/source/pyzes.py |
Adds driver API bindings and types. |
bindings/sysman/python/source/examples/pyzes_black_box_test.py |
Driver tests at lines 1536 and 1638 are incorrectly skipped when device enumeration fails or returns no devices. |
bindings/sysman/python/README.md |
Documents version 0.1.3 APIs while package and release metadata remain at 0.1.2. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
aviralni
force-pushed
the
pyzes_driver
branch
from
September 28, 2026 09:06
a6d2987 to
69aff0e
Compare
Add python bindings, unit tests, black box test coverage and README entries for: 1. zesDriverGetProperties 2. zesDriverGetExtensionProperties 3. zesDriverGetExtensionFunctionAddress 4. zesDriverEventListenEx 5. zesDriverEventRegisterExt 6. zesDriverEventListenExt Related-To: SYSM-433 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
…listen timeout to 10000 ms in pyzes black box test
Driver properties, extension and event queries do not need a device, but both -a and -d skipped them when device enumeration failed or returned no devices. Run the driver scoped test before the device check. Related-To: SYSM-433 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
Contributor
Author
…ox test The driver test queried zesDriverGetExtensionFunctionAddress for zesIntelDriverGetPropertiesExp. NEO removed that function when the driver properties moved to the standard zesDriverGetProperties, so the lookup now fails with ZE_RESULT_ERROR_INVALID_ARGUMENT. Query zesIntelDriverRescanDevicesExp instead, as zello_sysman does. Related-To: SYSM-433 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
…ck box test zello_sysman prints the driver properties with -D/--driverproperties and listens for events with -E/--event, while pyzes did both under -d, which is the diagnostics test in zello_sysman. Run the properties, extension and extension function tests with -D and the event registration and listen tests with -E; --listen-timeout now belongs to -E. Related-To: SYSM-433 Signed-off-by: Aviral Nigam <aviral.nigam@intel.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.