Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "minor",
"comment": "Export restricted import paths for extension by consuming projects",
"packageName": "@ni/eslint-config-javascript",
"email": "robert.milea@ni.com",
"dependentChangeType": "patch"
}
1 change: 1 addition & 0 deletions packages/eslint-config-javascript/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@ import { imports } from './lib/imports.js';
import { strict } from './lib/strict.js';

export { importNodeEsmConfig } from './lib/import-node-esm.js';
export { restrictedImportPaths } from './lib/es6.js';
export const javascriptConfig = defineConfig([
stylisticPlugin.configs['disable-legacy'],
bestPractices,
Expand Down
14 changes: 8 additions & 6 deletions packages/eslint-config-javascript/lib/es6.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
import { defineConfig } from 'eslint/config';

export const restrictedImportPaths = [{
// The following is recommended by the @angular-eslint/recommended--extra configuration.
// https://github.com/angular-eslint/angular-eslint/blob/v15.2.1/packages/eslint-plugin/src/configs/recommended--extra.json
name: 'rxjs/Rx',
message: 'Please import directly from \'rxjs\' instead'
}];

export const es6 = defineConfig([{
rules: {
/*
Expand Down Expand Up @@ -84,12 +91,7 @@ export const es6 = defineConfig([{
'no-restricted-imports': [
'error',
{
paths: [{
// The following is recommended by the @angular-eslint/recommended--extra configuration.
// https://github.com/angular-eslint/angular-eslint/blob/v15.2.1/packages/eslint-plugin/src/configs/recommended--extra.json
name: 'rxjs/Rx',
message: 'Please import directly from \'rxjs\' instead'
}]
paths: restrictedImportPaths
}],

/*
Expand Down
2 changes: 1 addition & 1 deletion tests/javascript/eslint.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ import { javascriptConfig } from '@ni/eslint-config-javascript';

export default defineConfig([
javascriptConfig,
]);
]);
Comment thread
jattasNI marked this conversation as resolved.
Loading