-
-
Notifications
You must be signed in to change notification settings - Fork 5k
feat: contacts import ocs #61277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SebastianKrupinski
wants to merge
1
commit into
feat/calendar-import-export-ocs
Choose a base branch
from
feat/contacts-import-ocs
base: feat/calendar-import-export-ocs
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+904
−7
Open
feat: contacts import ocs #61277
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\DAV\CardDAV\Import; | ||
|
|
||
| final readonly class ImportCountEvent implements ImportEvent { | ||
| public function __construct( | ||
| public int $vcard | ||
| ) { | ||
| } | ||
|
|
||
| public function total(): int { | ||
| return $this->vcard; | ||
| } | ||
|
|
||
| /** | ||
| * @return array{type: 'count', vcard: int} | ||
| */ | ||
| #[\Override] | ||
| public function jsonSerialize(): array { | ||
| return [ | ||
| 'type' => 'count', | ||
| 'vcard' => $this->total(), | ||
| ]; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\DAV\CardDAV\Import; | ||
|
|
||
| enum ImportDisposition: string { | ||
| case Created = 'created'; | ||
| case Updated = 'updated'; | ||
| case Exists = 'exists'; | ||
| case Error = 'error'; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\DAV\CardDAV\Import; | ||
|
|
||
| use JsonSerializable; | ||
|
|
||
| interface ImportEvent extends JsonSerializable { | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| <?php | ||
|
|
||
| declare(strict_types=1); | ||
| /** | ||
| * SPDX-FileCopyrightText: 2026 Nextcloud GmbH and Nextcloud contributors | ||
| * SPDX-License-Identifier: AGPL-3.0-or-later | ||
| */ | ||
|
|
||
| namespace OCA\DAV\CardDAV\Import; | ||
|
|
||
| final readonly class ImportObjectEvent implements ImportEvent { | ||
| /** | ||
| * @param list<string> $errors | ||
| */ | ||
| public function __construct( | ||
| public ?string $identifier, | ||
| public ImportDisposition $disposition, | ||
| public array $errors = [], | ||
| ) { | ||
| } | ||
|
|
||
| public function isError(): bool { | ||
| return $this->disposition === ImportDisposition::Error; | ||
| } | ||
|
|
||
| /** | ||
| * @return array{type: 'object', identifier: ?string, disposition: string, errors: list<string>} | ||
| */ | ||
| #[\Override] | ||
| public function jsonSerialize(): array { | ||
| $result = [ | ||
| 'type' => 'object', | ||
| 'identifier' => $this->identifier, | ||
| 'disposition' => $this->disposition->value, | ||
| 'errors' => $this->errors, | ||
| ]; | ||
|
|
||
| return $result; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What value does this interface add of it has no methods?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a common type for ImportCountEvent and ImportObjectEvent, its used to stream events all the way to the UI while processing.