feat: contacts import ocs#61277
Open
SebastianKrupinski wants to merge 1 commit into
Open
Conversation
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
SebastianKrupinski
force-pushed
the
feat/contacts-import-ocs
branch
from
9e175b9 to
7553769
Compare
SebastianKrupinski
added
3. to review
SebastianKrupinski
requested review from
ArtificialOwl,
ChristophWurst,
come-nc,
icewind1991 and
leftybournes
and removed request for
a team
|
|
||
| use JsonSerializable; | ||
|
|
||
| interface ImportEvent extends JsonSerializable { |
Member
There was a problem hiding this comment.
What value does this interface add of it has no methods?
Contributor
Author
There was a problem hiding this comment.
This is a common type for ImportCountEvent and ImportObjectEvent, its used to stream events all the way to the UI while processing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Checklist
3. to review, feature component)stable32)AI (if applicable)